Hi,
I am getting a build failure when buidling v2.5.4 without BQL:
src/netdev.c: In function 'e1000_clean_tx_ring':
src/netdev.c:2607: error: 'adapter' undeclared (first use in this function)
src/netdev.c:2607: error: (Each undeclared identifier is reported only once)
src/netdev.c:2607: error: for each function it appears in.)
make[3]: *** [/usr/src/packages/BUILD/kernel-smp64-3.8.13.13/modules-\
3.8.13.13/e1000e/module/src/netdev.o] Error 1
And in e1000_clean_tx_ring() there is:
#ifdef CONFIG_BQL
struct e1000_adapter *adapter = tx_ring->adapter;
#endif
struct e1000_buffer *buffer_info;
unsigned long size;
unsigned int i;
for (i = 0; i < tx_ring->count; i++) {
buffer_info = &tx_ring->buffer_info[i];
e1000_put_txbuf(tx_ring, buffer_info);
}
netdev_reset_queue(adapter->netdev);
As netdev_reset_queue() has been added for BQL specifically
I have now solved that by #ifdef'ing this call. See attached
patchlet.
Can someone please comment on this?
Thanks.
/Holger
I think we disabled BQL some time ago when building against kernel
v3.3 withour further ado, has there had been some reports about
packet delay if BQL was enabled.
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
