Hi,
I see a build failure when building against kernel v3.8 on a 32bit
system:
src/netdev.c:7948: error: 'e1000e_pm_suspend' undeclared here (not in a
function)
src/netdev.c:7949: error: 'e1000e_pm_resume' undeclared here (not in a
function)
And I see that the definition of e1000e_pm_suspend() depends on
CONFIG_PM_SLEEP, whereas the actual usage depends on CONFIG_PM with
this version of the driver.
For me making both places depend on CONFIG_PM only fixes the build
issue for me. See attached patchlet.
Relevant config parts (x86_32):
# CONFIG_SUSPEND is not set
# CONFIG_HIBERNATION is not set
CONFIG_PM_RUNTIME=y
CONFIG_PM=y
But for x86_64 I have:
# CONFIG_SUSPEND is not set
CONFIG_HIBERNATE_CALLBACKS=y
# CONFIG_HIBERNATION is not set
CONFIG_PM_SLEEP=y
CONFIG_PM_SLEEP_SMP=y
# CONFIG_PM_AUTOSLEEP is not set
# CONFIG_PM_WAKELOCKS is not set
CONFIG_PM_RUNTIME=y
CONFIG_PM=y
Wouldn't it be better to also depend those two callbacks on
CONFIG_SUSPEND? And then only register those two callbacks
if it is set?
Please check.
Thanks.
/Holger
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
