> -----Original Message----- > From: [email protected] [mailto:[email protected]] > On Behalf Of Jeff Kirsher > Sent: Monday, December 16, 2013 4:52 PM > To: Stephen Hemminger > Cc: [email protected]; [email protected] > Subject: Re: [PATCH net-next] igb: make local functions static and remove dead > code > > On Thu, 2013-12-12 at 12:09 -0800, Stephen Hemminger wrote: > > Make local functions static, and remove unused > > e1000_write_sfp_data_byte. > > > > Signed-off-by: Stephen Hemminger <[email protected]> > > > > --- > > drivers/net/ethernet/intel/igb/e1000_82575.c | 6 +++--- > > drivers/net/ethernet/intel/igb/e1000_i210.c | 18 > > +++++++++--------- > > drivers/net/ethernet/intel/igb/e1000_i210.h | 9 --------- > > drivers/net/ethernet/intel/igb/e1000_phy.c | 2 +- > > drivers/net/ethernet/intel/igb/e1000_phy.h | 1 - > > drivers/net/ethernet/intel/igb/igb.h | 2 -- > > drivers/net/ethernet/intel/igb/igb_ptp.c | 6 ++++-- > > 7 files changed, 17 insertions(+), 27 deletions(-) > > Did you compile test this patch? I am guessing no because we got the > following > compile errors: > drivers/net/ethernet/intel/igb/e1000_82575.c:2723: error: static declaration > of > âigb_get_thermal_sensor_data_genericâ follows non-static declaration > drivers/net/ethernet/intel/igb/e1000_82575.h:270: note: previous declaration > of âigb_get_thermal_sensor_data_genericâ was here > drivers/net/ethernet/intel/igb/e1000_82575.c:2777: error: static declaration > of > âigb_init_thermal_sensor_thresh_genericâ follows non-static declaration > drivers/net/ethernet/intel/igb/e1000_82575.h:269: note: previous declaration > of âigb_init_thermal_sensor_thresh_genericâ was here > make[5]: *** [drivers/net/ethernet/intel/igb/e1000_82575.o] Error 1 > make[5]: *** Waiting for unfinished jobs.... > make[4]: *** [drivers/net/ethernet/intel/igb] Error 2 > make[4]: *** Waiting for unfinished jobs.... > make[3]: *** [drivers/net/ethernet/intel] Error 2 > make[2]: *** [drivers/net/ethernet] Error 2 > make[1]: *** [drivers/net] Error 2 > make: *** [drivers] Error 2 > > I will work on a v2 to fix up these compiling issues.
Please note that removing the igb_get_eee_status_i354 function is the incorrect fix. There is another bug that is the missing code that uses this function. I'm working on it. Thanks, Carolyn ------------------------------------------------------------------------------ Rapidly troubleshoot problems before they affect your business. Most IT organizations don't have a clear picture of how application performance affects their revenue. With AppDynamics, you get 100% visibility into your Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro! http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
