On Sat, 2014-01-11 at 12:58 +0300, Dan Carpenter wrote:
> If "vf_id" is smaller than hw->func_caps.vf_base_id then it leads to
> an array underflow of the pf->vf[] array. This is unlikely to happen
> unless the hardware is bad, but it's a small change and it silences a
> static checker warning.
>
> Fixes: 7efa84b7abc1 ('i40e: support VFs on PFs other than 0')
> Signed-off-by: Dan Carpenter <[email protected]>
Tested-by: Sibai Li <[email protected]>
Signed-off-by: Aaron Brown <[email protected]>
> ---
> v2: rebased. commit message updated.
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> index 51a4f6125437..b77d7e79d977 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_virtchnl_pf.c
> @@ -1772,7 +1772,7 @@ int i40e_vc_process_vf_msg(struct i40e_pf *pf, u16
> vf_id, u32 v_opcode,
> u32 v_retval, u8 *msg, u16 msglen)
> {
> struct i40e_hw *hw = &pf->hw;
> - int local_vf_id = vf_id - hw->func_caps.vf_base_id;
> + unsigned int local_vf_id = vf_id - hw->func_caps.vf_base_id;
> struct i40e_vf *vf;
> int ret;
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
> _______________________________________________
> E1000-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/e1000-devel
> To learn more about Intel® Ethernet, visit
> http://communities.intel.com/community/wired
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
