From: Florian Fainelli <f.faine...@gmail.com> Date: Wed, 26 Feb 2014 14:44:00 -0800
> skb->pkt_type is not a bitmask, but contains only value at a time from > the range defined in include/uapi/linux/if_packet.h. > > Checking it like if it was a bitmask of values would also cause > PACKET_OTHERHOST, PACKET_LOOPBACK and PACKET_FASTROUTE to be matched by this > check since their lower 2 bits are also set, although that does not fix a real > bug due to how the checks are used, it is still potentially confusing. > > This bogus check was introduced in commit 815cccbf ("ixgbe: add setlink, > getlink support to ixgbe and ixgbevf"). > > Signed-off-by: Florian Fainelli <f.faine...@gmail.com> Intel folks, I assume you will pick this up? ------------------------------------------------------------------------------ Flow-based real-time traffic analytics software. Cisco certified tool. Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer Customize your own dashboards, set traffic alerts and generate reports. Network behavioral analysis & security monitoring. All-in-one tool. http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired