On Mon, 2014-05-19 at 14:04 +0200, Toralf Förster wrote: > spotted by cppcheck > > Signed-off-by: Toralf Förster <[email protected]> > --- > drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
I will add your patch to my queue and will hold off on making my
suggested change below until Shannon and Jesse have had time to review
your patch.
>
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> index 3c37386..1bc35a2 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> @@ -1239,7 +1239,7 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
> } else if (strncmp(cmd_buf, "add pvid", 8) == 0) {
> i40e_status ret;
> u16 vid;
> - int v;
> + unsigned int v;
Maybe u16 instead...
>
> cnt = sscanf(&cmd_buf[8], "%i %u", &vsi_seid, &v);
> if (cnt != 2) {
> @@ -1255,7 +1255,7 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
> goto command_write_done;
> }
>
> - vid = (unsigned)v;
> + vid = v;
> ret = i40e_vsi_add_pvid(vsi, vid);
> if (!ret)
> dev_info(&pf->pdev->dev,
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ "Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE Instantly run your Selenium tests across 300+ browser/OS combos. Get unparalleled scalability from the best Selenium testing platform available Simple to use. Nothing to install. Get started now for free." http://p.sf.net/sfu/SauceLabs
_______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
