On 21.07.2014 [12:53:33 -0700], Alexander Duyck wrote: > I do agree the description should probably be changed. There shouldn't be > any panics involved, only a performance impact as it will be reallocating > always if it is on a node with no memory.
Yep, thanks for the review. > My intention on this was to make certain that the memory used is from the > closest node possible. As such I believe this change likely honours that. Absolutely, just wanted to make it explicit that it's not a functional fix, just a performance fix (presuming this shows up at all on systems that have memoryless NUMA nodes). I'd suggest an update to the comments, as well. Thanks, Nish ------------------------------------------------------------------------------ Want fast and easy access to all the code in your enterprise? Index and search up to 200,000 lines of code with a free copy of Black Duck Code Sight - the same software that powers the world's largest code search on Ohloh, the Black Duck Open Hub! Try it now. http://p.sf.net/sfu/bds _______________________________________________ E1000-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
