Hi Bernhard, + This query shows me only your mail as result, so AFAICS it's "bit-banged I2C", not + bit-bagned (the "n" must be before the "g") and a grep in the Kernel source only + finds "banged": + + https://www.google.com/search?q=%22bit-bagned%22+I2c
Quite right! I'll change that in the relevant places... + This patch adds the i2cbb kernel module parameter, which allows to + It wasn't immediately clear that "bb" means "bit-banged" - I guess using another + name might make the name less mysterious. I chose that name since 1. The driver already registers the busses to the OS as "igb BB" 2. Module parameters controlling other features also use short acronyms (MDD, RSS, LLIPush, etc.) + + /* Bit-bagned i2c flag. */ + Proposal for an updated comment that would be helpful for people reviewin just the + source code itself (my guess): + /* Flag for exposing the SFP pins as I2C bus for custom I350 boards */ Actually, the patch will expose the busses for all boards & devices, unconditionally. What about: /* Flag for unconditionally exposing the SFP pins as I2C bus (not just i350) */ + + uint i2cbb; + +IGB_PARAM(I2CBB, + + "Bit-bagned i2c busses (0/1), default 0 = disabled. Always enabled on i350."); + +#endif /* HAVE_I2C_SUPPORT */ + Is it safe to enable it in all i350 boards (even other custom boards - we also have + one) as this suggests? Possibly not - the user would need to know what he is doing. I we were to enable it only on boards for which we know that this is safe, I don't know what would be the right criteria for determining if it can safely be done or not. The case I'm trying to address with this series of patches in one of a custom board with a 82580 chip, to which a full-fledged i2c bus is attached, with 2+ i2c devices. However, I don't think this patch needs to be 82580-specific. + As far as I understand, this changes if a pin is pulled high or low by the I350. I confess I'm not familiar with the i350 board; which pin are you referring to? Under which criteria will it be pulled high or low? + + + + .name = "Bit-bagned i2c", + Maybe grep your patches for "bagned" to fix all typos, Will do. Thanks! Jh ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
