Recently I test linux device drivers in Linux 3.17.2, and find some potential bugs.
e100 driver: The target file is drivers/net/ethernet/intel/e100.c, which is used to build e100.ko. I hope you can help me check my findings: [1] The function pci_pool_create is called by e100_probe when initializing the ethernet card driver. But when pci_pool_create is failed, which means that it returns NULL to nic->cbs_pool, the system crash will happen. Because pci_pool_alloc (in e100_alloc_cbs in e100_up in e100_open) need to use nic->cbs_pool to allocate the resource, but it is NULL. I suggest that a check can be added in the code to detect whether pci_pool_create returns NULL. [2] In the normal process, netif_napi_add is called in e100_probe, but netif_napi_del is not called in e100_remove. However, many other ethernet card drivers call them in pairs, even in the error handling paths, such as r8169 and igb. Could you help me check these findings? Thank you very much, and I'm looking forward to your reply. -- Jia-Ju Bai ------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
