On Sat, 2014-12-20 at 16:02 +0800, Jia-Ju Bai wrote: > I have actually tested e1000e driver on the real hardware(Intel > 82572EI > PCI-E Gigabit Ethernet Controller), and find some potential bugs: > The target file is drivers/net/ethernet/intel/e1000e/netdev.c, which > is used > to build e1000e.ko. > > (1) In the normal process, netif_napi_add is called in e1000_probe, > but > netif_napi_del is not called in e1000_remove. However, many other > ethernet > card drivers call them in pairs, even in the error handling paths, > such as > r8169 and igb. > > (2) The function vzalloc is called by e1000e_setup_rx_resources (in > e1000_open) when initializing the ethernet card driver. But when > vzalloc is > failed, "err" segment in e1000e_setup_rx_resources is executed to > return and > then e1000e_free_tx_resources in "err_setup_rx" segment in e1000_open > is > executed to halt. However, "writel(0, tx_ring->head)" statement in > e1000_clean_tx_ring in e1000e_free_tx_resources will cause system > crash, > because "tx_ring->head" is not assigned the value. In the code, > "tx_ring->head" is initialized in e1000_configure_tx in > e1000_configure > after the e1000e_setup_rx_resources. > (3) The same system crashes happens, when kcalloc in > e1000e_setup_rx_resources is failed(returns NULL). > (4) The same system crashes happens, when e1000_alloc_ring_dma in > e1000e_setup_rx_resources is failed(returns error code). > > (5) In the normal process of e1000e, pci_enable_pcie_error_reporting > and > pci_disable_pcie_error_reporting is called in pairs in e1000_probe and > e1000_remove. However, when pci_enable_pcie_error_reporting has been > called > and pci_save_state in e1000_probe is failed, "err_alloc_etherdev" > segment in > e1000_probe is executed immediately to exit, but > pci_disable_pcie_error_reporting is not called. > (6) The same situation happens when alloc_etherdev_mqs in e1000_probe > is > failed. > (7) The same situation happens when ioremap in e1000_probe is failed. > (8) The same situation happens when e1000_sw_init in e1000_probe is > failed. > (9) The same situation happens when register_netdev in e1000_probe is > failed. > > (10) When request_irq in e1000_request_irq is failed, > pm_qos_add_request in > e1000_open is called, but pm_qos_remove_request is not called. > > Meanwhile, I also write the patch to fix the bugs. I have run the > patch on > the hardware, it can work normally and fix the above bugs.
Again, is this an issue you saw or a theoretical issue? > > diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c > b/drivers/net/ethernet/intel/e1000e/netdev.c > index 247335d..02d1e67 100644 > --- a/drivers/net/ethernet/intel/e1000e/netdev.c > +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > @@ -2444,6 +2444,8 @@ static void e1000_clean_tx_ring(struct > e1000_ring > *tx_ring) > tx_ring->next_to_use = 0; > tx_ring->next_to_clean = 0; > > + if(!(tx_ring->head)) > + return; Need a space between the 'if' and the (). Please check your patches by running checkpatch.pl on them before sending them out.
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your Business Reports and Dashboards with Interactivity, Sharing, Native Excel Exports, App Integration & more Get technology previously reserved for billion-dollar corporations, FREE http://pubads.g.doubleclick.net/gampad/clk?id=164703151&iu=/4140/ostg.clktrk
_______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
