On Thu, 25 Dec 2014 10:02:36 +0800
Jia-Ju Bai <baijiaju1...@163.com> wrote:
> The driver lacks netif_napi_del in the normal path and error path to
> match the call of netif_napi_add in e100_probe.
> This patch fixes this problem, and it has been tested on the hardware.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1...@163.com>
> ---
> drivers/net/ethernet/intel/e100.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/e100.c
> b/drivers/net/ethernet/intel/e100.c
> index 781065e..21c4d0f 100644
> --- a/drivers/net/ethernet/intel/e100.c
> +++ b/drivers/net/ethernet/intel/e100.c
> @@ -2985,6 +2985,7 @@ err_out_free_res:
> err_out_disable_pdev:
> pci_disable_device(pdev);
> err_out_free_dev:
> + netif_napi_del(&nic->napi);
> free_netdev(netdev);
This is unnecessary since already done in free_netdev()
void free_netdev(struct net_device *dev)
{
..
list_for_each_entry_safe(p, n, &dev->napi_list, dev_list)
netif_napi_del(p);
.
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
