NACK. The fix is incorrect and just invalidates the case statement in general.

The TX hang message really doesn't tell you anything and it would be more 
useful to see the full logs. We'll need a lot more information to debug this 
issue. I would suggest filing the issue on sourceforge with all the usual full 
info:

OS version
Kernel version
CPU information (model number and speed)
Motherboard information (model number)
Memory (how much, what speed, what size)
dmesg
ethtool -S ethX
ethtool -i ethX
cat /proc/interrupts
cat /var/log/messages
lspci -vvv

Todd Fujinaka
Software Application Engineer
Networking Division (ND)
Intel Corporation
todd.fujin...@intel.com
(503) 712-4565

-----Original Message-----
From: Tony Battersby [mailto:to...@cybernetics.com] 
Sent: Wednesday, January 07, 2015 6:59 AM
To: e1000-devel@lists.sourceforge.net
Subject: [E1000-devel] [PATCH] igb: fix Tx Unit Hang on 82576 with RSS > 1

On my Supermicro X8DTH-6F motherboard, the onboard 82576 ethernet ports are 
completely inoperable with the latest igb from sourceforge when using RSS > 1.  
This is the error message:

igb 0000:01:00.0: Detected Tx Unit Hang
  Tx Queue             <0>
  TDH                  <0>
  TDT                  <1>
  next_to_use          <1>
  next_to_clean        <0>
buffer_info[next_to_clean]
  time_stamp           <10000b131>
  next_to_watch        <ffff88032f1f4000>
  jiffies              <10000b3b4>
  desc.status          <a8000>

Known-good versions:
  sourceforge igb-5.2.5.tar.gz and earlier
  upstream in-kernel igb

Known-bad versions:
  sourceforge igb-5.2.9.2.tar.gz and later

The patch below reverts the change that is causing the problem.

Signed-off-by: Tony Battersby <to...@cybernetics.com>
---

--- igb-5.2.15/src/igb_main.c.orig      2014-09-18 12:12:17.000000000 -0400
+++ igb-5.2.15/src/igb_main.c   2015-01-06 17:47:07.000000000 -0500
@@ -408,7 +408,7 @@ static void igb_cache_ring_register(stru
                                adapter->rx_ring[i]->reg_idx = rbase_offset +
                                                                Q_IDX_82576(i);
                }
-       break;
+               /* Fall through */
        case e1000_82575:
        case e1000_82580:
        case e1000_i350:


------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website, sponsored 
by Intel and developed in partnership with Slashdot Media, is your hub for all 
things parallel software development, from weekly thought leadership blogs to 
news, videos, case studies, tutorials and more. Take a look and join the 
conversation now. http://goparallel.sourceforge.net 
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit 
http://communities.intel.com/community/wired

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit 
http://communities.intel.com/community/wired

Reply via email to