On Mon, Jan 26, 2015 at 2:48 PM, Dev, Vasu <vasu....@intel.com> wrote: >> -----Original Message----- >> From: Kirsher, Jeffrey T >> Sent: Sunday, January 25, 2015 9:10 PM >> To: nick; Dev, Vasu >> Cc: e1000-devel@lists.sourceforge.net >> Subject: Re: [E1000-devel] Return Value for the function, u32 >> i40e_fcoe_ctxt_eof in i40e_fcoe_ctx_eof >> >> On Sat, 2015-01-24 at 18:20 -0500, nick wrote: >> > I am wondering what the correct error return value is for the function >> > stated in my message. >> >> What message? In the title you state "Return Value for the function, >> u32 i40e_fcoe_ctxt_eof in i40e_fcoe_ctx_eof", are you referring to your >> message title? >> >> > In addition I am assuming the return should be -EINVAL as the value is >> > not supported for this function. Please let me known if I wrong or >> > should send in a patch fixing this. >> >> Please no patches Nick, based on past experience, I am guessing you have >> found a FIXME comment in our driver code and you are attempting to >> resolve it. Please allow our developers (specifically Vasu Dev) to resolve >> any >> FIXME comments they have made in the code. >> > I'll fix this. > > However this is not an issue at all since errored default is not reachable > condition. > I mean early on all possible switch cases are already checked by " > i40e_fcoe_eof_is_supported()". > However just from the func sanity better to error out instead of relying on > its early callers > as that may change. > > Thanks, > Vasu > Sure that's fine. I am just trying to help out. :) In addition if I remember I also am getting a build warning for a no longer supported function in the same file. If you want I can send in another message with the warning I am getting. Nick
------------------------------------------------------------------------------ Dive into the World of Parallel Programming. The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
