On Thu, 2015-03-19 at 16:31 +0300, Dan Carpenter wrote:
> Static checkers complain about this because we do:
>
> if (!(connsw & E1000_CONNSW_SERDESD)) {
> ...
> } else if (connsw & E1000_CONNSW_SERDESD) {
> ...
> } else {
> ...
> }
>
> Once you eliminate that E1000_CONNSW_SERDESD is set and not set then
> there aren't any other possibilities so the else statement is dead
> code.
>
> This function always returns zero so if you delete the "ret_val"
> variable, the code is shorter and more clear.
>
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>Thanks Dan, surprised we did not see this earlier. I have added your patch to my queue. -- git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
signature.asc
Description: This is a digitally signed message part
------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________ E1000-devel mailing list E1000-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/e1000-devel To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired
