>-----Original Message-----
>From: Du, Fan
>Sent: Tuesday, April 14, 2015 8:12 PM
>To: Kirsher, Jeffrey T
>Subject: [PATCH] ixgbevf: Set rx hash type for ingress packets
>
>Set hash type for ingress packets according to NIC
>advanced receive descriptors RSS type part.
>
>also use le16_to_cpu forcing type conversion to slient
>endian check warnings.
>
>Signed-off-by: Fan Du <fan...@intel.com>
>---
> drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
> drivers/net/ethernet/intel/ixgbevf/defines.h | 12 ++++++++
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 30 +++++++++++++++++++++
> 3 files changed, 43 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>index 8915992..1b3b5fb 100644
>--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
>@@ -1359,7 +1359,7 @@ static int __ixgbe_notify_dca(struct device *dev, void
>*data)
> #endif /* CONFIG_IXGBE_DCA */
> static inline enum pkt_hash_types ixgbe_get_hash_type(__le16 pkt_info)
> {
>- switch (pkt_info & cpu_to_le16(IXGBE_RXDADV_RSSTYPE_MASK)) {
>+ switch (le16_to_cpu(pkt_info) & IXGBE_RXDADV_RSSTYPE_MASK) {
This appears to be a fix for your ixgbe patch and does not belong here. The
proper way to handle it is to submit
version 2. Also checkout my reply to your ixgbe patch - it has the logic we use
in ixgbe and there are some differences
that we need to address before we can accept this. Like the IPV4/6 extensions
defines are not included and in the case of rss_type being 0 RSS is nor
performed and so we probably should not call set_skb_hash() in that situation.
Thanks,
Emil
------------------------------------------------------------------------------
BPM Camp - Free Virtual Workshop May 6th at 10am PDT/1PM EDT
Develop your own process in accordance with the BPMN 2 standard
Learn Process modeling best practices with Bonita BPM through live exercises
http://www.bonitasoft.com/be-part-of-it/events/bpm-camp-virtual- event?utm_
source=Sourceforge_BPM_Camp_5_6_15&utm_medium=email&utm_campaign=VA_SF
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
