>-----Original Message-----
>From: Tal Abudi [mailto:talab...@gmail.com]
>Sent: Wednesday, July 01, 2015 8:54 AM
>To: e1000-devel@lists.sourceforge.net
>Subject: [E1000-devel] ethtool -L fails on 82598 controllers (tc <
>IXGBE_DCB_MAX_TRAFFIC_CLASS)
>
>Hi
>I'm using ethtool -L to change the number of RX channels.
>I see that it doesn't work on my ixgbe 82598 controllers.
>The problem is in ixgbe_setup_tc()
>if (tc > adapter->dcb_cfg.num_tcs.pg_tcs ||
> (hw->mac.type == ixgbe_mac_82598EB &&
> tc < IXGBE_DCB_MAX_TRAFFIC_CLASS)) {
>return -EINVAL;
>}
>
>The value of tc is 0 (< 8 (IXGBE_DCB_MAX_TRAFFIC_CLASS)) because DCB is
>disabled.
>Why is that ? Is it safe to disable this piece of code ?
>Thanks !
Looks like a bug, the check for 82598 did not account for when tc=0.
Try following patch (against 4.1.1):
--- ixgbe_main.c_orig 2015-04-29 17:13:22.000000000 -0700
+++ ixgbe_main.c 2015-07-06 12:55:14.842090873 -0700
@@ -9115,9 +9115,11 @@ int ixgbe_setup_tc(struct net_device *de
struct ixgbe_hw *hw = &adapter->hw;
/* Hardware supports up to 8 traffic classes */
- if (tc > adapter->dcb_cfg.num_tcs.pg_tcs ||
- (hw->mac.type == ixgbe_mac_82598EB &&
- tc < IXGBE_DCB_MAX_TRAFFIC_CLASS))
+ if (tc > adapter->dcb_cfg.num_tcs.pg_tcs)
+ return -EINVAL;
+
+ if (tc && hw->mac.type == ixgbe_mac_82598EB &&
+ tc < IXGBE_DCB_MAX_TRAFFIC_CLASS)
return -EINVAL;
/* Hardware has to reinitialize queues and interrupts to
Thanks for reporting it.
Emil
>
>--
>Best regards,
>Tal Abudi
>
>---------------------------------------------------------------------------
>---
>Don't Limit Your Business. Reach for the Cloud.
>GigeNET's Cloud Solutions provide you with the tools and support that
>you need to offload your IT needs and focus on growing your business.
>Configured For All Businesses. Start Your Cloud Today.
>https://www.gigenetcloud.com/
>_______________________________________________
>E1000-devel mailing list
>E1000-devel@lists.sourceforge.net
>https://lists.sourceforge.net/lists/listinfo/e1000-devel
>To learn more about Intel® Ethernet, visit
>http://communities.intel.com/community/wired
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
