> From: Richard Cochran [[email protected]]
> Sent: Thursday, October 29, 2015 3:27 AM
> To: Gangfeng Huang
> Cc: [email protected]
> Subject: Re: [E1000-devel] [PATCH net-next 2/2] igb: add a character device
> to support AVB
>
> On Thu, Oct 29, 2015 at 09:47:36AM +0800, Gangfeng Huang wrote:
> > This patch is reference to the Intel Open-AVB project:
> > http://github.com/AVnu/Open-AVB/tree/master/kmod/igb
>
> You know that this kind of HW specific, chardev interface has very
> little chance of being accepted mainline, don't you?
>
> The idea of having a time based packet scheduler as a new interface in
> the networking stack is attractive, but it would need to be a generic
> solution. Also, this kind of work must be posted to the netdev list
> for proper review.
>
Based on Richard's feedback I think I have ask that you follow his suggestion
to post this to the netdev list to get a wider audience for proper review
before I spend any significant time testing this. But is is getting some test
attention and I notice checkpatch is complains about which side fo the test a
constant is on:
--------------------------------------------------------------------------------------------
u1458:[1]/usr/src/kernels/next-queue> git format-patch bc4267d -1
--stdout|./scripts/checkpatch.pl -
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#99:
new file mode 100644
WARNING: Comparisons should place the constant on the right side of the test
#198: FILE: drivers/net/ethernet/intel/igb/igb_cdev.c:95:
+ if (NULL == adapter)
...
repeated 7 more times on different lines
...
total: 0 errors, 8 warnings, 0 checks, 866 lines checked
Your patch has style problems, please review.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
u1458:[1]/usr/src/kernels/next-queue>
--------------------------------------------------------------------------------------------
Thanks
Aaron
------------------------------------------------------------------------------
_______________________________________________
E1000-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit
http://communities.intel.com/community/wired
