Thank you so much for your quick help here.
I'm fine with adding the code back into my local copy for now and am
looking forward to your next driver release.
Kind regards,
Philipp
On Fri, Sep 11, 2020 at 10:39 PM Fujinaka, Todd <todd.fujin...@intel.com> wrote:
>
> The ethtool fixes ended up in the driver that is set to be released "soon",
> scheduled for Q3 so that meant by the end of the month in original scheduling.
>
> The fixes enabled the toggling of 2.5G and 5G. If you need it now, I'd
> suggest adding the code back in. The fixes should be upstream now and in the
> next standalone driver that's coming "soon".
>
> Upstream commit is: a296d665eae1 ("ixgbe: Add ethtool support to enable 2.5
> and 5.0 Gbps support", 2020-07-01)
>
> Todd Fujinaka
> Software Application Engineer
> Data Center Group
> Intel Corporation
> todd.fujin...@intel.com
>
> -----Original Message-----
> From: Philipp Wollermann <philipp.wollerm...@gmail.com>
> Sent: Friday, September 11, 2020 11:45 AM
> To: Fujinaka, Todd <todd.fujin...@intel.com>
> Cc: e1000-devel@lists.sourceforge.net
> Subject: Re: [E1000-devel] ixgbe 5.8.1 dropped support for NBase-T in X550
>
> Thank you for your quick response and detailed information, Todd. I totally
> understand where you are coming from.
>
> Per your suggestion, I have now tried to manually enable the auto negotiation
> advertising of the NIC to include 2500baseT and 5000baseT via ethtool:
>
> ethtool -s enp65s0f0 advertise 0x1800000001028
>
> However I cannot get this to work:
> - With vanilla ixgbe 5.7.1 and my patched ixgbe 5.8.1 the NIC advertise 2.5G
> and 5G by default after booting, but as soon as I touch the "ethtool -s
> $ifname advertise" setting in any way, the NIC will no longer advertise 2.5G
> and 5G speeds until a reboot and only offers 100M, 1G, 10G.
> - With vanilla ixgbe 5.8.1 it does not advertise 2.5G or 5G by default after
> a boot, and I cannot get it to advertise these speeds via ethtool.
>
> FWIW, ethtool also does not show 2.5G or 5G as supported or advertised link
> modes.
>
> The README of ixgbe 5.8.1 indeed says:
> "Devices that support AQRate (X550 and later) will include 2.5 Gbps and 5
> Gbps in the speeds that the driver advertises during auto-negotiation, even
> though ethtool will not display 2.5 Gbps or 5 Gbps as "Supported link modes"
> or "Advertised link modes." These speeds are only available through
> unmodified auto-negotiation. You cannot use ethtool -s advertise to force
> auto-negotiation to advertise 2.5 Gbps or 5 Gbps."
>
> I have tried with ethtool 4.19 from the latest Debian 10.5 and also the
> latest ethtool 5.8 from kernel.org.
>
> Can you confirm that you're able to enable 2.5G and 5G advertising via
> ethtool?
>
> Kind regards,
> Philipp
>
>
>
>
> On Fri, Sep 11, 2020 at 8:01 PM Fujinaka, Todd <todd.fujin...@intel.com>
> wrote:
> >
> > The short answer is that we needed to turn it off by default because of
> > interoperability issues with switches that were pre-standards, and you can
> > turn it back on using ethtool.
> >
> > There were two ways we could fix this: ask the people with the switches to
> > upgrade their switch firmware, or turn off default advertisements for 2.5G
> > and 5G. The customers with the switches objected vehemently to having to
> > touch all their switches, and there were a lot of customers complaining.
> > This is the first time I've heard of anyone asking for 2.5G or 5G outside
> > of the telecom space, so we went with the option of changing the default.
> >
> > Check the ethtool man page for more information, but there's a bitmask of
> > speeds and modes under ethtool -s that you need to set.
> >
> > Todd Fujinaka
> > Software Application Engineer
> > Data Center Group
> > Intel Corporation
> > todd.fujin...@intel.com
> >
> > -----Original Message-----
> > From: Philipp Wollermann <philipp.wollerm...@gmail.com>
> > Sent: Thursday, September 10, 2020 1:30 PM
> > To: e1000-devel@lists.sourceforge.net
> > Subject: [E1000-devel] ixgbe 5.8.1 dropped support for NBase-T in X550
> >
> > Hi,
> >
> > after upgrading from ixgbe 5.7.1 to 5.8.1, my X550-T2 NICs can no longer
> > auto-negotiate a link with 2.5Gb/s or 5GB/s.
> >
> > I diffed the code and noticed that in src/ixgbe_phy.c the following lines
> > were removed:
> >
> > case ixgbe_mac_X550:
> > hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
> > hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
> > break;
> >
> > Indeed, when reverting just this change, ixgbe 5.8.1 successfully brings up
> > links with 2.5Gb/s and 5 Gb/s again.
> >
> > As the change has not been mentioned in the release notes as an intentional
> > feature removal, I wonder if it's an accidental regression?
> >
> > Kind regards,
> > Philipp
> >
> > --
> > Philipp Wollermann | Software Engineer | phi...@google.com Google
> > Germany GmbH | Erika-Mann-Straße 33 | 80636 München
> >
> > Geschäftsführer: Paul Manicle, Halimah DeLaine Prado Registergericht
> > und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft: Hamburg
> >
> >
> > _______________________________________________
> > E1000-devel mailing list
> > E1000-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/e1000-devel
> > To learn more about Intel Ethernet, visit
> > https://forums.intel.com/s/topic/0TO0P00000018NbWAI/intel-ethernet
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel Ethernet, visit
https://forums.intel.com/s/topic/0TO0P00000018NbWAI/intel-ethernet
