Hi Tom, I think it should be much easier to write custom widgets. The ETab* classes could for example be in Nebula. I had some discussions with Steve on this subject about allowing clients to extend and draw their own graphics within the custom widgets, leaving the basic widget behaviour/structure in place, which matches exactly what we wanted to do here. I think something along those lines is the right strategy in the future.
WRT. the fragment, yes I really regret the added complexity in setup. The only other choices I see are: 1) Forgo the new widgets, just pull them 2) Copy CTab*. But then we need to copy listeners, and databinding, and... Any other suggestions? Regards, Kevin Tom Schindl <[email protected]> Sent by: [email protected] 07/16/2009 10:07 AM Please respond to E4 Project developer mailing list <[email protected]> To E4 Project developer mailing list <[email protected]> cc Subject Re: [e4-dev] Cant't compile current e4 trunk Hi Kevin, Is there really a plan to move this code back to SWT? I don't know the history of CTabFolder but IMHO it was also created because of a nice IDE L&F requirement and because there was only SWT at the time being it was put there. The ETabFolder stuff looks like is going into the same direction and I think it should not get part of SWT because it is what it is a custom component developed for a nice E4 L&F. If you agree with me on this then it suddenly doesn't make much sense any more to make it an SWT-Fragment, right (I understand why you did this - you can access/overload package-visible methods - but I questions whether such a stragey is best practice? As a side note: --------------- After having struggled now for more than an hour to get all running on Cocoa_64 + SWT 3_5 + SWT_x86_64 - I gave up switched to Java 5 + SWT 3_5 + SWT_x86. What I'd like to say with this is that this simple small decision causes many headaches and probably drops off potential contributors because they don't even get something running. Tom Kevin McGuire schrieb: > > Sorry, you now also need to load SWT :( You will want to load the R3_5 > version (assuming your IDE is 3.5 final). > > For the record, I apologize for the hassle and confusion I've > introduced, but I couldn't see any other solution and really felt it > important for us to be able to update our tab look to move the eclipse > look forward. > >>> For the moment this puts us in the position where to compile e4 UI we >>> need to check out org.eclipse.swt (and set the .classpath correctly >>> for your platform) so that org.eclipse.e4.ui.widgets.fragment can >>> compile. Without a compiled version of >>> org.eclipse.e4.ui.widgets.fragment the swt.renderer plugin will no >>> longer compile. > >>See _http://www.eclipse.org/swt/cvs.php_ for instructions on how to > check out SWT from CVS. > > > > *"Toedter, Kai" <[email protected]>* > Sent by: [email protected] > > 07/09/2009 09:29 AM > Please respond to > E4 Project developer mailing list <[email protected]> > > > > To > "E4 Project developer mailing list" <[email protected]> > cc > > Subject > RE: [e4-dev] Cant't compile current e4 trunk > > > > > > > > > Found the project org.eclipse.e4.ui.widgets.fragment. The reason I did > not find in the first place was that it does not compile in my > environment... > > It looks good thought, so I will try to find out what's wrong with my > environment... > > Kai > >> -----Original Message----- >> From: [email protected] [mailto:[email protected]] On >> Behalf Of Toedter, Kai >> Sent: Donnerstag, 9. Juli 2009 15:14 >> To: E4 Project developer mailing list >> Subject: [e4-dev] Cant't compile current e4 trunk >> >> All, >> >> I get compile errors in >> org.eclipse.e4.workbench.ui.renderers.swt.StackModelFactory >> >> Cannot resolve: >> import org.eclipse.swt.custom.ETabFolder; >> import org.eclipse.swt.custom.ETabItem; >> >> In which project should these classes be? >> >> Thanx >> >> Kai >> --- >> >> Kai Tödter >> >> Siemens AG >> Corporate Technology >> Architecture >> CT SE 2 >> Otto-Hahn-Ring 6 >> 81739 Munich, Germany >> Phone: +49 89 636-41064 >> Fax: +49 89 636-45450 >> mailto: [email protected] >> Internet: www.siemens.com/corporate-technology >> >> Siemens Aktiengesellschaft: Chairman of the Supervisory Board: Gerhard >> Cromme; Managing Board: Peter Loescher, Chairman, President and Chief >> Executive Officer; Heinrich Hiesinger, Joe Kaeser, Rudi Lamprecht, >> Eduardo Montes, Juergen Radomski, Erich R. Reinhardt, Hermann Requardt, >> Uriel J. Sharef, Peter Y. Solmssen, Klaus Wucherer; Registered offices: >> Berlin and Munich; Commercial registries: Berlin Charlottenburg, HRB >> 12300, Munich, HRB 6684; WEEE-Reg.-No. DE 23691322 >> >> >> _______________________________________________ >> e4-dev mailing list >> [email protected] >> https://dev.eclipse.org/mailman/listinfo/e4-dev > _______________________________________________ > e4-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/e4-dev > > > ------------------------------------------------------------------------ > > _______________________________________________ > e4-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/e4-dev -- B e s t S o l u t i o n . a t EDV Systemhaus GmbH ------------------------------------------------------------------------ tom schindl geschaeftsfuehrer/CEO ------------------------------------------------------------------------ eduard-bodem-gasse 5/1 A-6020 innsbruck phone ++43 512 935834 _______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
