Is this the work which removes the need of the. If I get it right ALL applications who use commands in some way need this.
Wouldn't it be better if they are contributed through a ModelProcess or once we have our XPath contribution working using a fragment? What worries me a bit about those addons is that the bundle who contributes the Addon-Element to the model (e.g. contacts-bundle) is NOT the owner of the class (core.commands.service). I know that this is possible but I don't think it is good practice when we think into a more dynamic direction. e.g. the bundle contributing the addon-class is updated, uninstalled, ... we need to remove the addon and re-add it but if the addon-element owner is different to the addon-class we are probably getting into trouble. The Addon-Element is generally a problem in this sense. What about the following. a) The addons are contributed through a ModelProcessor b) The model processor checks if there is a tag for the addon in the MApplication-Element e.g.: addon:org.eclipse.e4.ui.workbench.addons.swt:DnDAddon addon:org.eclipse.e4.core.commands:CommandServiceAddon ... and only then contributes this addon. This way the one defines the Addon-Handler-Class is also the one who contributes the addon-element. Tom Am 23.11.10 14:36, schrieb Paul Webster: > As part of Bug 329646 [1] I've cleaned up the command lifecycle to use > add-ons to properly integrate with the model. That means an e4 app > needs 2 addons in its model to function correctly: > > <addons xmi:id="_XGB3wPZlEd-XstlTZ6nTXg" > elementId="org.eclipse.e4.core.commands.service" > contributionURI="platform:/plugin/org.eclipse.e4.core.commands/org.eclipse.e4.core.commands.CommandServiceAddon"/> > <addons xmi:id="_LK0NgPZmEd-XstlTZ6nTXg" > elementId="org.eclipse.e4.ui.workbench.commands.model" > contributionURI="platform:/plugin/org.eclipse.e4.ui.workbench/org.eclipse.e4.ui.internal.workbench.addons.CommandProcessingAddon"/> > > To run the compatibility layer against HEAD, you need to have the > org.eclipse.platform project checked out into your workspace: > > dev.eclipse.org:/cvsroot/eclipse org.eclipse.platform R4_HEAD > > I'll be making the same changes to the context management and key > binding management over the next little while as well. I'll post to the > list when I release my changes with the implications (I can think of :-) > > [1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=329646 > Bug 329646 - Keybindings aren't found or shown when run from .jars > > -- > Paul Webster > Hi floor. Make me a sammich! - GIR > > > > _______________________________________________ > e4-dev mailing list > e4-dev@eclipse.org > https://dev.eclipse.org/mailman/listinfo/e4-dev -- B e s t S o l u t i o n . a t EDV Systemhaus GmbH ------------------------------------------------------------------------ tom schindl geschaeftsfuehrer/CEO ------------------------------------------------------------------------ eduard-bodem-gasse 5/1 A-6020 innsbruck phone ++43 512 935834 _______________________________________________ e4-dev mailing list e4-dev@eclipse.org https://dev.eclipse.org/mailman/listinfo/e4-dev
