Hi Eric, Thanks for your detailed descriptions. I'll continue my work on the theme and my vision of a perfect dark theme and then I'll let you know where there needs to be more options for styling. And then we can go into greater detail. But for now, I think I first need to optimize the theme with all the settings I currently have. I'll keep you updated!
Cheers Roger On Tuesday, 10. July 2012 at 17:33, Eric Moffatt wrote: > > Kai / Roger, > > We have two different techniques that might help out here...sorry but I'll > have to paraphrase the CSS since I'm not truly familiar with the syntax. > > For styling 'content' (i.e. the tree control used by the Package Explorer) > it's fairly straightforward to define the CSS as 'Tree inside an MPart'. Same > idea of course applies to Tables (Problems view, Error Log...) and StyledText > (Editors...) This will cover some of the attributes but likely will still > have issues with JFace's implementation of the [Styled]LabelProvider...we may > need to extend JFace here either by extending its current label providers (if > we want to style existing components whose code is not under our control) and > / or creating a new CSSLabelProvider for direct use by new code. > > For 'native' widgets (i.e. the previously mentioned LabelProvider) we can > also *query* the CSS engine to gather up the appropriate values in code and > 'apply' them directly. For an example of this look at how the TrimStack's > frame is done; the Images are programmatically extracted from the CSS and > used in the custom ImageBasedFrame. To see how the mechanics work look at > CSSRenderingUtils. This technique is extremely general and should be capable > of being used to solve a great many issues as long as we're willing to write > the custom code to use it...all the necessary hooks are already in place > (such as being able to add a 'Reskin' listener to handle theme switching). > > I'm not sure how to handle corner cases such as dialogs, especially 'system' > dialogs....again we might want to see what extensions we may need to JFace > here. > > If you could provide a couple of specific use cases I'd be happy to see if I > can rig up a demo of how they might be done. > > Thanks for all your attention to this, > Eric > > > From: > "Toedter, Kai" <[email protected] (mailto:[email protected])> > > To: > E4 Project developer mailing list <[email protected] > (mailto:[email protected])> > > Date: > 07/10/2012 10:12 AM > > Subject: > Re: [e4-dev] Themes for Eclipse 4 > > Sent by: > [email protected] (mailto:[email protected]) > > > > > > > > Hi Roger, > > > This is one of my main concerns as well. Do we have any chance to style > > them as well? > Currently I don’t know any solution. I guess the best chance is to contact > the SWT guys directly to get their opinion on how to proceed here. > > Best regards, > > Kai > > From: [email protected] (mailto:[email protected]) > [mailto:[email protected]] On Behalf Of Roger Dudler > Sent: Dienstag, 10. Juli 2012 16:02 > To: E4 Project developer mailing list > Subject: Re: [e4-dev] Themes for Eclipse 4 > > Hi Kai, > > This is one of my main concerns as well. Do we have any chance to style them > as well? > > PS: I've attached a screenshot of the early version. > > Cheers > Roger > On Tuesday, 10. July 2012 at 15:52, Toedter, Kai wrote: > Roger, > > Could you please provide a screenshot of your “dark” theme? My main concern > is how to deal with native widgets that are not stylable via CSS. > > Thanks > > Kai > > > From: [email protected] (mailto:[email protected]) > [mailto:[email protected]] On Behalf Of Lars Vogel > Sent: Dienstag, 10. Juli 2012 15:38 > To: E4 Project developer mailing list > Subject: Re: [e4-dev] Themes for Eclipse 4 > > Hi Roger, > > great news! Could you re-share the dark theme which you created? It look to > me that it did not survive the forwarding. I assume you are past this point > but I have a little Eclipse 4 CSS tutorial here: > http://www.vogella.com/articles/Eclipse4CSS/article.html > > If you do not use it already you should have a look at Brians CSS Spy which > is also briefly described in the tutorial. > > Best regards, Lars > 2012/7/10 Eric Moffatt <[email protected] (mailto:[email protected])> > > Roger, I'm really glad for your attention to this ! We'll help out where ever > we can...note that neither the SWT CSS bindings nor our use of them are cast > in stone, if you see something you think would be useful just let us know and > we'll work it out. > > We also have the ability to use our CSS implementation as a query engine, > able to respond in code with the value it would use for a particular > control's CSS state.This has proven very useful when we want CSS control over > something that's not intrinsic to any particular SWT widget (the minimized > stack's 'frame' is done this way using a utility class called > CSSRenderingUtils). One use that I haven't implemented yet is that we should > be able to define images to fill the sash gutters but keep it in mind, we're > not strictly limited to the SWT bindings themselves. > > If you need anything else just drop me a line... > > BTW, I've added the 'e4-dev' list to the CC so that we can move the > discussion to a wider auduence... > > Onwards, > Eric > From: > John Arthorne/Ottawa/IBM > > To: > Roger Dudler <[email protected] (mailto:[email protected])> > > Cc: > Bogdan Gheorghe/Ottawa/IBM@IBMCA, Brian de Alwis <[email protected] > (mailto:[email protected])>, Eric Moffatt/Ottawa/IBM@IBMCA > > Date: > 07/06/2012 02:09 PM > > Subject: > Re: Themes for Eclipse 4 > > > > > > > > > The dark theme looks great! I'll defer to others for the more technical > questions. Some people are on holiday this week so your best bet might be to > fire a question to the list and see how is around to answer. Anyway, great > stuff. I look forward to seeing more. > > John > > Roger Dudler <[email protected] (mailto:[email protected])> > 07/06/2012 12:29 PM > > > To > John Arthorne/Ottawa/IBM@IBMCA > > cc > > Bogdan Gheorghe/Ottawa/IBM@IBMCA, Brian de Alwis <[email protected] > (mailto:[email protected])>, Eric Moffatt/Ottawa/IBM@IBMCA > > Subject > > Re: Themes for Eclipse 4 > > > > > > > > > > > > Hey John, > > After some hours I managed to create a basic dark theme. It still needs some > work for all special properties, but it already looks cool :) > > I will continue to work on this dark theme and let you know when it's > finished. After I've discovered the necessary set of properties, we can > generate themes based on editor color themes on http://eclipsecolorthemes.org > (http://eclipsecolorthemes.org/). That's a massively requested feature. > People will love it :) > > I have some questions / comments, maybe you can help: > > - Is there a way to get PNG icons with alpha transparency instead of those > with the white pixels around them? > - Am I right that many of the CSS definitions don't inherit their styles from > parent rules? > - The theme switcher in "Appearance" is a little bit buggy and doesn't > reflect the current version of the CSS all the time (not easy to handle, when > creating themes) > > PS: I signed up to the e4-dev mailing list and will post additional feedback > there > > Cheers > Roger > On Friday, 6. July 2012 at 15:22, John Arthorne wrote: > Hi Roger, > > I have added Bogdan Gheorghe to the CC list, who is our main platform styling > expert. There is some reasonable documentation to get started with here: > > http://wiki.eclipse.org/Eclipse4/RCP/CSS > http://wiki.eclipse.org/E4/CSS/SWT_Mapping > > More questions welcome though. e4-dev would be a good place to ask questions > because most of the CSS styling experts hang out there: > > http://dev.eclipse.org/mhonarc/lists/e4-dev/ > > John > Ian Skerrett <[email protected] (mailto:[email protected])> > 07/06/2012 09:03 AM > > > > To > Brian de Alwis <[email protected] (mailto:[email protected])>, Eric > Moffatt/Ottawa/IBM@IBMCA, John Arthorne/Ottawa/IBM@IBMCA, Roger Dudler > <[email protected] (mailto:[email protected])> > > cc > > > > Subject > > Fwd: Re: Themes for Eclipse 4 > > > > > > > > > > > > > Eric, Brian and John, > > I would like to introduce you to Roger Dudler. Roger is one of the > co-developers of the very popular Eclipse Color Theme > (http://marketplace.eclipse.org/content/eclipse-color-theme) plugin. Roger > is interested in seeing if he could do some Eclipse 4 CSS themes but he is > finding the documentation lacking. :-( > > Do you guys know of any examples or pointers Roger could use? I think it > would be a huge win for Eclipse 4 if we could get Roger's plugin to be > supporting Eclipse 4 CSS Themes. > > Thanks > Ian > > > -------- Original Message -------- > > Subject: > > Re: Themes for Eclipse 4 > > Date: > > Fri, 6 Jul 2012 08:53:53 +0200 > > From: > > Roger Dudler <[email protected]> (mailto:[email protected]) > > To: > > Ian Skerrett <[email protected]> (mailto:[email protected]) > > > > > > > > > Hey, > > I'm definitely interested in creating a platform/builder for Eclipse 4 > themes. Maybe it might be a good kickstart to just create one really good one > by ourself, because I've not found any themes out there yet. It still seems > to be difficult or because lack of documentation. I'll look into it and try > to create a dark theme based on the new theming css. This is what I can do > first. You can support me by sending links/documents about the new theming > features for a better start (if you have some secret ones ;). > > Cheers > Roger > On Thursday, 5. July 2012 at 20:51, Ian Skerrett wrote: > Roger, > > Not sure how much I can contribute but I will certainly help promote any > effort to the Eclipse community. > > There has been some discussion about have a competition to create different > Eclipse 4 themes. Maybe we can create a community effort to do it? > > Ian > > > > On 7/4/2012 3:51 PM, Roger Dudler wrote: > Hey Ian, > > We haven't had a talk about Eclipse 4 yet. I'll need to check that with > Felix, the other developer. It would be nice to just have an Eclipse 4 > version available for all current themes. I'm not sure how easy the mapping > will be from the old hundreds of settings to the new ones. Are you interested > in contributing to the topic? > > Cheers > Roger > On Wednesday, 4. July 2012 at 21:03, Ian Skerrett wrote: > Hi Roger, > > Does Eclipse Themes work with Eclipse 4? Eclipse 4 is a lot easier to create > different themes, so I was wondering if you guys have considered doing > something specific for Eclipse 4? > > I hope things are well. > > Ian > > -- > Ian Skerrett > VP of Marketing and Ecosystem > Eclipse Foundation > Tel: 613-224-9461 ext 227 (tel:613-224-9461%20ext%20227) > Blog: ianskerrett.wordpress.com (http://ianskerrett.wordpress.com/) > Twitter: IanSkerrett (http://twitter.com/IanSkerrett) > > > -- > Ian Skerrett > VP of Marketing and Ecosystem > Eclipse Foundation > Tel: 613-224-9461 ext 227 (tel:613-224-9461%20ext%20227) > Blog: ianskerrett.wordpress.com (http://ianskerrett.wordpress.com/) > Twitter: IanSkerrett (http://twitter.com/IanSkerrett) > [attachment "eclipse4-dark-theme.png" deleted by Eric Moffatt/Ottawa/IBM] > > _______________________________________________ > e4-dev mailing list > [email protected] (mailto:[email protected]) > https://dev.eclipse.org/mailman/listinfo/e4-dev > > _______________________________________________ > e4-dev mailing list > [email protected] (mailto:[email protected]) > https://dev.eclipse.org/mailman/listinfo/e4-dev > _______________________________________________ > e4-dev mailing list > [email protected] (mailto:[email protected]) > https://dev.eclipse.org/mailman/listinfo/e4-dev > > > _______________________________________________ > e4-dev mailing list > [email protected] (mailto:[email protected]) > https://dev.eclipse.org/mailman/listinfo/e4-dev > >
_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
