Should we not also create a service for ContextInjectionFactory? Feels wrong to use a Factory to perform the dependency injection.
2013/3/7 Eric Moffatt <[email protected]> > > OK, here's the third part http://wiki.eclipse.org/Eclipse4/API/AppContext, > giving Services and other elements (@Named things) that are guaranteed to > be available from the application's (window's?) context. My comments are > already on the wiki. Again everybody feel free to comment... > > I'll let the wiki soak for a bit to give everyone a chance to have their > say and then refine the pages based on the feedback. > > Everyone should look for missing things such as the Life Cycle annotations. > > Over the next few days we expect to be taking the initial code actions > necessary (i.e. changing packages to API and adding @NoReference etc to > stuff we don't want to formalize (yet)). > > On the model side we expect to *remove* the more funky of the menu / tb > items as well as adding in an MCompositePart (an MPart that is also an > MPartSashContainer (to support split parts...). > > Now that I understand what @Active does and that the ESelectionService > actually contains more functionality than is available through DI (i.e. > 'post' selection listeners) the only remaining question that I'm aware of > is which of ContextFunction / IContextFunction we should go with... > > Also I've added the IEventBroker to the list of services since even though > most listeners should be able to use the @Topic annotation there's no way > to *unregister* transient listeners using DI... > > If we can get it done I'd really like to have this (at least mostly) > available in M6. Then I'd ask folks that have tutorials / examples etc to > check whether they still have any references to non-API in them and figure > out if it's something we missed or whether we should update the code to use > the proper API... > > Thanks a lot for the feedback so far, keep it up ! > Eric > > _______________________________________________ > e4-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/e4-dev > >
_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
