Lars, Eric & al, - Lars, I've signed the Eclipse CLA
- Eric, I've reviewed and commented bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=424367 - Lars, I've reviewed ModelService changes in https://git.eclipse.org/r/#/c/19311/ . Seems like there's nothing for finding MCommands, MKeybindings, and that the handling of MHandlers is incomplete, since it does not do a deep search (e.g. would find the MHandlers directly below an MApplication, but not those declared in the context of another definition inside the MApplication - such as MPart, etc.). Would like to check my understand with you here first, before polluting the Gerrit Change. - Eric, you write "I'm all for adopting API that will work with Clojure unless it makes the java API too strange" and that's sweet. In fact, I do find the proposed API strange, where you suggest taking an object for the Filter, with an annotation (to be created separately) for the filtering method. Are interfaces totally banned? Cheers, -- Laurent 2013/12/18 Eric Moffatt <[email protected]> > Guys, I've opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=424367 to > track some of these issues...take a look an comment freely...;-). > > Laurent, I'm all for adopting API that will work with Clojure unless it > makes the java API too strange so please comment if you more appropriate > calling patterns as we go along... > > Should we carry the conversation on here or move it over to the defect ?? > > Onwards, > Eric > > > [image: Inactive hide details for Laurent PETIT ---12/18/2013 10:22:36 > AM---OK Lars, that's noted. I will do it tomorrow (working full]Laurent > PETIT ---12/18/2013 10:22:36 AM---OK Lars, that's noted. I will do it > tomorrow (working full time on CCW by thursdays) > > > > From: > > > Laurent PETIT <[email protected]> > > To: > > > E4 Project developer mailing list <[email protected]>, > > Date: > > > 12/18/2013 10:22 AM > > Subject: > > > Re: [e4-dev] Dynamic Eclipse 4 with Clojure language > > Sent by: > > > [email protected] > ------------------------------ > > > > OK Lars, that's noted. I will do it tomorrow (working full time on CCW by > thursdays) > > > 2013/12/18 Lars Vogel <*[email protected]* <[email protected]>> > > Laurent, just a reminder, changes in Eclipse requires also some time. > The earlier to create bug reports for your requirements the soon someone > might have the chance to look at them. Also Eclipse is closing in its > release cycle soon for new features. > > The current development for the ModelService happens in > > *https://git.eclipse.org/r/#/c/19311/*<https://git.eclipse.org/r/#/c/19311/>, > would be good if you can check if you requirement for finding all elements > is covered. I tried to add you as reviewer but it looks to me that you not > yet registered as Gerrit user. See here how to register: > > *http://www.vogella.com/articles/Gerrit/article.html#eclipsegerritcontribution*<http://www.vogella.com/articles/Gerrit/article.html#eclipsegerritcontribution> > > > 2013/12/16 Lars Vogel <*[email protected]* <[email protected]>> > > *https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform*<https://bugs.eclipse.org/bugs/enter_bug.cgi?product=Platform> > with > component UI would be the right place IMHO. > > > 2013/12/16 Laurent PETIT > <*[email protected]*<[email protected]> > > > Hi Lars, > > I will open the bug requests, indeed. > > Are there things I should know about the bug tracker system > itself, and / or the bug request submission process ? (I mean things > that > may appear different than what I am used to. I'm not a total newbie > ;-) , > but I'm a newbie in submitting Eclipse bug requests, so maybe there > are > idiosyncracies I should be aware of ?) > > > > > > 2013/12/16 Lars Vogel <*[email protected]*<[email protected]> > > > Hi Laurent, > > sounds like we should add some API to support your use case. > Please see inline answers to Pauls comments. > > Best regards, Lars > > On Fri, Dec 13, 2013 at 9:02 AM, Laurent PETIT < > *[email protected]* <[email protected]>> wrote: > This lets room for MKeybinding, MHandler, MCommand. A > method like findByTags(theApp, MHandler.class, List<String> > tags) would > work for the first part of my usecase. > > I would expect that we would provide a more generic > version of > > org.eclipse.e4.ui.workbench.modeling.EModelService.findElements(MUIElement, > String, Class<T>, List<String>, int) > > Something that could be used: > > List<MHandler> elements = service.find(root, null, > MHandler.class, tags, 0); > > If I understand Pauls comment correctly we should open a bug > request for this new method. @Laurent, can you please open a bug > report for > this feature? > > > But I would still be out of luck concerning the second > part of my use case: removing the MHandler instance from > its parent > MHandlerContainer. > > If we have a way to provide a parent, I think that we'd > probably expose another EModelService method: > > Object parent = service.getParent(handlerModel); > > Again, if I understand Pauls comment correctly we should open > a bug request for this new method. @Laurent, can you please open > a bug > report for this feature? > > Later, > PW > > -- > Paul Webster > Hi floor. Make me a sammich! - GIR > > _______________________________________________ > e4-dev mailing list > *[email protected]* <[email protected]> > *https://dev.eclipse.org/mailman/listinfo/e4-dev*<https://dev.eclipse.org/mailman/listinfo/e4-dev> > > > _______________________________________________ > e4-dev mailing list > *[email protected]* <[email protected]> > *https://dev.eclipse.org/mailman/listinfo/e4-dev*<https://dev.eclipse.org/mailman/listinfo/e4-dev> > > > _______________________________________________ > e4-dev mailing list > *[email protected]* <[email protected]> > *https://dev.eclipse.org/mailman/listinfo/e4-dev*<https://dev.eclipse.org/mailman/listinfo/e4-dev> > > > _______________________________________________ > e4-dev mailing list > *[email protected]* <[email protected]> > *https://dev.eclipse.org/mailman/listinfo/e4-dev*<https://dev.eclipse.org/mailman/listinfo/e4-dev> > > _______________________________________________ > e4-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/e4-dev > > > > _______________________________________________ > e4-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/e4-dev > >
<<graycol.gif>>
<<ecblank.gif>>
_______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
