The other radical approach is that we are not setting any image paths (in pure e4) anymore and completely rely on CSS.
Tom On 23.01.14 09:49, Tom Schindl wrote: > Well finally I think this should be married with the image registry I > invented for the e4-tools, which would give us automagic image disposal! > > Tom > > On 23.01.14 09:46, Marco Descher wrote: >> Ah I see, >> >> sorry for missing out on that! No, my solution is not dynamic! But I guess >> it would >> not be much of a problem to make it dynamic! What I liked about our approach >> is, that >> it is both possible to access the icons out of the code, and out of the app >> model. Making >> this additionally dynamic would probably cope for every requirement?! >> >> Considering your dynamic approach I think that a combined solution would >> really be great! >> Just consider having your dynamic approach also available for Actions and >> centralized for >> the overall application. >> >> cheers, marco >> >> >> An 23. Jänner 2014 at 09:41:02, Tom Schindl ([email protected]) >> schrieb: >>> >>> The main idea is that this is dynamic! I can remember having read >>> your >>> article but maybe I missed that your solution is dynamic? >>> >>> Please note that my proposal does adapt dynamically at runtime >>> so that >>> e.g. the ToolItem when becoming disabled will get a different >>> image, if >>> an operation is running the parts gets a different icon, ... . >>> >>> Tom >>> >>> On 23.01.14 09:36, Marco Descher wrote: >>>> Hy Tom, >>>> >>>> I had a shot on this with a different solution: >>>> >>>> See EclipseMagazin 2.2013 - i created a bundle adding a new URL >>> Handler, namely icon:// >>>> were I could use static allocations like icon://PERSON which >>> worked out quite well! It is >>>> extended with a fragment, which allows for easy exchange of >>> the complete icon set for the >>>> whole application. >>>> >>>> I think this approach could be extended to create an AddOn managing >>> all icons, allowing >>>> to address them icon:// style! >>>> >>>> Thanks, >>>> marco >>>> >>>> >>>> An 23. Jänner 2014 at 09:27:54, Tom Schindl ([email protected]) >>> schrieb: >>>>> >>>>> Hi, >>>>> >>>>> While reading an article from Marc Teufel on an Eclipse 4 application >>>>> it >>>>> reminded me of something I wanted to purpose since some time >>> already >>>>> (I >>>>> also saw a bug flying by to allow one to control the icons via >>> CSS!). >>>>> >>>>> Anyways here we go. The idea is fairly simple and already known >>>>> from 3.x >>>>> where one can use a fixed set of variables in the image paths. >>>>> >>>>> I'd like to extend this to use all variables of the IEclipseContext >>>>> so >>>>> one can write an image URL like this: >>>>> >>>>> platform:/plugin/icons/${themeId}/${enabled}/img.png >>>>> >>>>> What do you think, does this make sense? >>>>> >>>>> Tom >>>>> _______________________________________________ >>>>> e4-dev mailing list >>>>> [email protected] >>>>> https://dev.eclipse.org/mailman/listinfo/e4-dev >>>>> >>>> >>>> _______________________________________________ >>>> e4-dev mailing list >>>> [email protected] >>>> https://dev.eclipse.org/mailman/listinfo/e4-dev >>>> >>> >>> _______________________________________________ >>> e4-dev mailing list >>> [email protected] >>> https://dev.eclipse.org/mailman/listinfo/e4-dev >>> >> >> _______________________________________________ >> e4-dev mailing list >> [email protected] >> https://dev.eclipse.org/mailman/listinfo/e4-dev >> > > _______________________________________________ > e4-dev mailing list > [email protected] > https://dev.eclipse.org/mailman/listinfo/e4-dev > _______________________________________________ e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/e4-dev
