Dan,
I have some comments about the features you suggest.
North, Dan (Contractor) wrote:
> Oops, sorry - a bit quick on the send key there!
>
> A couple of things I've noticed while using the "introduce field"
> refactoring:
>
> Firstly, I tried introducing a variable using a key mapping
> (ctrl-alt-V). This only works if the whole variable name is selected,
> otherwise the current line gets selected and I get a message telling me
> that the selected block should represent an expression. This is
> inconsistent with Move (shift-F6), which works out the field name based
> on where the cursor is.
Quick and easy way to introduce variable for a field is to press
Ctrl-W, thus selecting the field name the caret is in, before you
press Ctrl-Alt-V.
"Introduce Variable" works essentialy _on expressions_, (as opposed
to "Move" you mentioned, which works on class members). So, if you caret
is at a field name, it is not at all clear whether you mean to introduce
variable for this field, or for expression enclosing it.
To select the whole line if the current operation needs selection and
nothing is selected, is a standard policy maintained throughout IDEA.
>
> Secondly, if you introduce a variable, then use the "convert local to
> field" refactoring, you don't get to choose things like visibility
> (private, public, etc) or modifiers (static, final).
We actually plan to merge "Introduce Field" and "Convert Local To
Field" refactorings. Then the functionality available will be the same
in both refactorings.
> If you introduce a
> field based on a constant value, then you get the full dialog. Also, my
> key mapping for "introduce field" has the same annoying behaviour
> whereby I have to have selected the variable rather than just having the
> cursor there.
All said above about "Introduce Variable" applies to "Introduce Field".
>
> Really minor, but really irritating when you're introducing a LOT of fields!
>
> Cheers,
> Dan/tastapod
>
Friendly,
Dmitry
--
Dmitry Lomov
JetBrains Inc. / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"
_______________________________________________
Eap-bugs mailing list
[EMAIL PROTECTED]
http://lists.jetbrains.com/mailman/listinfo/eap-bugs
