Maxim,

You have a point there.

I thought it was actually supposed to check if any potentially occurring
exceptions are being catched. But I guess that's the compilers task.

Thanks

Regards,
 
Patrick M. Ansari
[EMAIL PROTECTED]
 
------------------------------------
186 East Road, R5.1
CB1 1BG Cambridge, Cambridgeshire
United Kingdom
Phone: +44 (0) 1223 475578
------------------------------------

-----Original Message-----
From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
On Behalf Of Maxim Shafirov
Sent: 08 April 2002 16:04
To: Patrick M. Ansari
Subject: Re: [Eap-list] [615] Code Inspection: Exception suggested

Hello Patrick,

Isn't it quite correct? close call could actually throw NPE. Inspector
just does not bother if certain exception get's the chance to be
catched.
IMHO it would be much more clear to check

 if (outBuff != null) outBuff.close();
 
instead of catching an exception here.

-- 
Best regards,
Maxim Shafirov
JetBrains, Inc / IntelliJ Software
http://www.intellij.com
"Develop with pleasure!"

PMA> finally
PMA>         {
PMA>             try
PMA>             {
PMA>                 outBuff.close();
PMA>             }
PMA>             catch (Exception e)
PMA>             {
PMA>                 e.printStackTrace();
PMA>             }
PMA>         }
 
PMA> Keeps telling me that .close() could throw a NullPointerException
even
PMA> though all exceptions should be covered by Exception e..
 
PMA>  .
 
PMA> Regards,
 
PMA> Patrick M. Ansari
PMA> [EMAIL PROTECTED]
 
PMA> ------------------------------------
PMA> 186 East Road, R5.1
PMA> CB1 1BG Cambridge, Cambridgeshire
PMA> United Kingdom
PMA> Phone: +44 (0) 1223 475578
PMA> ------------------------------------


_______________________________________________
Eap-list mailing list
[EMAIL PROTECTED]
http://www.intellij.com/mailman/listinfo/eap-list




_______________________________________________
Eap-list mailing list
[EMAIL PROTECTED]
http://www.intellij.com/mailman/listinfo/eap-list

Reply via email to