Hi Franky,
On Wednesday 28 October 2015 15:41:40 Backeljauw Franky wrote:
> [snip]
>
> So do I get it right that EB explicitly sets ‘usempi: False’ somewhere?
>
> Let’s look at the Easyblock for MUMPS (mumps.py), this contains:
>
> # pick a Makefile.inc template based on compiler family and MPI
> enabled
if self.toolchain.options.get('usempi', None):
> make_inc_suff = 'PAR'
> else:
> make_inc_suff = 'SEQ'
>
> If EB would not set `usempi:False` explicitly, then the test
> get(‘usempi’,None) results in None which implies True so the parallel build
> will be made :-('None' is 'False' in Python! Or am I getting something wrong here? > If on the other hand EB explicitly sets ‘usempi:False’, then wouldn’t it be > better to change this test to “if self.toolchain.options[‘usempi’] = False” > instead? > Furthermore, is there a check to make sure ‘usempi’ is either False or True > (or None)? > — Regards, > > Franky > > Torbjörn
signature.asc
Description: This is a digitally signed message part.
