Dear Loris,
On 18/03/2020 10:42, Loris Bennett wrote:
Hi,
If I have Github integration set up and I want to make changes to
someone else's PR, what would be the best workflow for that?
This use case is not particularly well supported right now in EasyBuild
itself, since it involves pulling in the branch used for that PR first.
Here's what I usually do:
1) Add the fork of the PR author using "git remote add AUTHOR URL",
where AUTHOR is the PR author's GitHub account, and URL is the URL to
their fork (see "git remote -v" for inspiration).
2) Pull in their branches, using "git fetch AUTHOR".
3) Check out their branch, using "git checkout PR_BRANCH_NAME"
4) Make changes
5) Send a PR to their branch, using "eb --new-pr --pr-target-account
ACCOUNT --pr-target-branch PR_BRANCH_NAME ...", where you replace the
"..." with the changed easyconfigs.
You can use "eb --new-pr -D" or "eb --new-pr -x" here first to double
check on yourself.
There's a couple of caveats to this, but it usually works out well.
regards,
Kenneth
Cheers,
Loris
