Yves, These are very pretty! It's sure nice to be able to understand the model from a simple picture to truly appreciate its simplicity.
I personally like to see a model with the inheritance and associations all in one picture so it's easier to know associations that are available as a result of inheritance. Of course it can get cluttered and is more difficult to render... Tom, Because Java doesn't support multiple class inheritance, when EMF is generating an Impl class, it will pick the Impl class of the first ECass.eSuperTypes as the class it extends and then mix-in the other implementations for additional eSuperTypes. For this reason, it's best to use EStyle as the first eSuperType of EStyleClass and EGUIModelElement as it avoids the duplicate code for all the style features and their accessors. As Marcelo mentioned, it's kind of gross to use EBooleanObject (java.lang.Boolean) instead of EBoolean (boolean), but I know you wanted to match the starting model closely. The same comment applies for EIntegerObject. Given how many booleans there are in this model, using primitives along with the generator option to pack them into bit fields will save like 28 bytes per instance (and more for derived types with yet more booleans). The new option in https://bugs.eclipse.org/bugs/show_bug.cgi?id=226815 would allow the enum value to be packed away for yet another 4 bytes of saving per instance. Compared to a map-based implementation, the memory footprint would be dramatically smaller with this more structured approach. I'm curious about the intended distinction between EStyle and EStyleClass? It it also good that a GUI Model Element is a Style rather than has a Style? It will save many objects to take that approach, so it's probably a good thing, but it makes me wonder why not just merge EStyle and EStyleClass and have EGUIModelElement extends the merged result? I've never been a big fan of multiples with multiple inheritance. I wonder if some of the things that are EJavaObject will eventually be more strongly typed? Ed Merks/Toronto/[EMAIL PROTECTED] mailto: [EMAIL PROTECTED] 905-413-3265 (t/l 313) "Yves YANG" <[EMAIL PROTECTED] c.com> To Sent by: "'E4 developer list'" eclipse-incubator <[EMAIL PROTECTED] [EMAIL PROTECTED] rg> clipse.org cc <[EMAIL PROTECTED] clipse.org> 04/17/2008 04:40 Subject AM RE: EMF backed Workbench (Was Re: [eclipse-incubator-e4-dev] Initialdiscussion on the 'modelled' Please respond to workbench UI) E4 developer list <eclipse-incubato [EMAIL PROTECTED] org> I have prepared in two diagrams: Inheritance and association view. Hope they are helpful. yves -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Ed Merks Sent: Wednesday, April 16, 2008 7:32 PM To: E4 developer list Cc: E4 developer list; [EMAIL PROTECTED] Subject: Re: EMF backed Workbench (Was Re: [eclipse-incubator-e4-dev] Initialdiscussion on the 'modelled' workbench UI) Tom, I've attached the Team Project Set file for ease of use as well as an Ecore Tools class diagram (which needs from formatting attention, but I have a meeting coming up): (See attached file: e4.presentationmodel.psf) (Embedded image moved to file: pic15632.jpg) Ed Merks/Toronto/[EMAIL PROTECTED] mailto: [EMAIL PROTECTED] 905-413-3265 (t/l 313) Tom Schindl <[EMAIL PROTECTED] solution.at> To Sent by: E4 developer list eclipse-incubator <[EMAIL PROTECTED] [EMAIL PROTECTED] rg> clipse.org cc Subject 04/16/2008 01:05 Re: EMF backed Workbench (Was Re: PM [eclipse-incubator-e4-dev] Initial discussion on the 'modelled' workbench UI) Please respond to E4 developer list <eclipse-incubato [EMAIL PROTECTED] org> My current sources are now available in CVS under: * e4-incubator/ui/org.eclipse.e4.presentationmodel.pure.emf * e4-incubator/ui/org.eclipse.e4.presentationmodel.pure.emf.workbench Tom -- B e s t S o l u t i o n . a t EDV Systemhaus GmbH ------------------------------------------------------------------------ tom schindl leiter softwareentwicklung/CSO ------------------------------------------------------------------------ eduard-bodem-gasse 8/3 A-6020 innsbruck phone ++43 512 935834 _______________________________________________ eclipse-incubator-e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/eclipse-incubator-e4-dev [attachment "Presentation-i.png" deleted by Ed Merks/Toronto/IBM] [attachment "Presentation-a.png" deleted by Ed Merks/Toronto/IBM] _______________________________________________ eclipse-incubator-e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/eclipse-incubator-e4-dev _______________________________________________ eclipse-incubator-e4-dev mailing list [email protected] https://dev.eclipse.org/mailman/listinfo/eclipse-incubator-e4-dev
