Hello,

I noticed in an application that I would find spurious error messages
in my stdout stream (which was redirected to a log file).  I think that
the source might be in src/c/error.d::FElibc_error() where indeed the
strerror(3) provided buffer is both printed on stdout and then included
in the sent signal.

Since the signal holds the error already, and that user code can then
print it, and since the debugger would also print it to an interactive
user on the debugger stream, it's probably not necessary to print the
error there.  If for another reason it should be printed, stderr would
probably be a better choice anyway, so I suspect it's a remnant of
earlier debugging code which was forgot there afterwards.

ecl_internal_error() on the other hand seems alright to me.

I also think that it would be best if the condition signaled in
FElibc_error() also included the errno value which would have use to
signal handlers, not only the string representation.

Thanks,
-- 
Matt

------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Ecls-list mailing list
Ecls-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ecls-list

Reply via email to