[
http://jira.nuxeo.org/browse/NXP-4117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61063#action_61063
]
Anahide Tchertchian commented on NXP-4117:
------------------------------------------
Made methods handling errors safer, and mark transaction as rollback only when
a error is caught.
http://hg.nuxeo.org/nuxeo/nuxeo-services/rev/d7f8c633884b
http://hg.nuxeo.org/nuxeo/nuxeo-jsf/rev/6c37a31ebb13
http://hg.nuxeo.org/nuxeo/nuxeo-dm/rev/c4bb2d360fb7
Transaction is still not rollbacked correctly, i will create a new issue for
this problem.
TODO: commit and add selenium tests on an addon performing errors for testing
purpose.
> Fix error handling for errors happening in nuxeo restful phase listener
> -----------------------------------------------------------------------
>
> Key: NXP-4117
> URL: http://jira.nuxeo.org/browse/NXP-4117
> Project: Nuxeo Enterprise Platform
> Issue Type: Bug
> Affects Versions: 5.2 GA
> Reporter: Anahide Tchertchian
> Assignee: Anahide Tchertchian
> Fix For: 5.3.x
>
> Attachments: dm-NXP-4117.diff, jsf-NXP-4117.diff,
> services-NXP-4117.diff
>
>
> The error handling methods put the system in a bad state when issuing an
> error in RestFulPhasListener class. This can be reproduced trying to access a
> page with an unknow view id, or trying to acess a document without READ
> rights.
> http-127.0.0.1-8080-1 - 2009-10-02 15:38:01,895 ERROR
> [org.jboss.seam.web.ExceptionFilter] handling uncaught exception
> java.lang.IllegalStateException
> at
> com.sun.faces.context.FacesContextImpl.assertNotReleased(FacesContextImpl.java:395)
> at
> com.sun.faces.context.FacesContextImpl.getExternalContext(FacesContextImpl.java:147)
> at
> com.sun.faces.util.RequestStateManager.getStateMap(RequestStateManager.java:276)
> at
> com.sun.faces.util.RequestStateManager.remove(RequestStateManager.java:243)
> at
> com.sun.faces.context.FacesContextImpl.release(FacesContextImpl.java:345)
> at javax.faces.webapp.FacesServlet.service(FacesServlet.java:283)
> at
> org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
> at
> org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
> at
> org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:83)
> at
> org.jboss.seam.web.MultipartFilter.doFilter(MultipartFilter.java:85)
> at
> org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at
> org.jboss.seam.web.ExceptionFilter.doFilter(ExceptionFilter.java:64)
> at
> org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at org.jboss.seam.web.RedirectFilter.doFilter(RedirectFilter.java:45)
> at
> org.jboss.seam.servlet.SeamFilter$FilterChainImpl.doFilter(SeamFilter.java:69)
> at
> org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:178)
> at org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:290)
> at
> org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:368)
> at org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:495)
> at org.jboss.seam.web.Ajax4jsfFilter.doFilter(Ajax4jsfFilter.java:60)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.nuxeo.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
ECM-tickets mailing list
[email protected]
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets
