improve routing FT test
-----------------------

                 Key: NXCM-175
                 URL: https://jira.nuxeo.org/browse/NXCM-175
             Project: Nuxeo Case Management
          Issue Type: Improvement
            Reporter: Alexandre Russel



I have some remarks about nuxeo-platform-document-routing.
You choose not to build the distribution module by default, so you created two 
jobs: one for building nuxeo-platform-document-routing (except its distribution 
module), one for building nuxeo-platform-document-routing-distribution and 
running Selenium tests against it. Why not, it seems a good idea... but
addons_nuxeo-platform-document-routing-5.4 was not set to prevent the project 
from building when a dependency of this project is in the queue or building
If you changed this behavior for a quick and fast build, please don't forget to 
set it back. It's really important as it prevents from performing useless 
builds.
FT_addons_nuxeo-platform-document-routing-5.4's naming doesn't follow current 
standards (such as addons_FT-nuxeo-platform-faceted-search-5.4) and so is not 
visible on view "NX 5.4 addons"
looking at the build-and-test.sh script, 
line 3: first comment seems wrong ("# Build Nuxeo Case Management")
line 4: "mvn clean install || exit 1" is useless as a deployment have been done 
by addons_nuxeo-platform-document-routing-5.4 just before
line 5: "mvn -Pserver ...", server profile seems unused, am I wrong ?
line 5: "... clean install", you do not "deploy" the distribution artifact 
because it's for testing purpose only and nobody would need to depend on it, 
right ? So, there's no need to "install" it, "package" is enough.
line 8: "... unzip ...", no need to unzip what you just zipped and which is 
still present in target
looking at 
nuxeo-platform-document-routing-distribution/src/main/assemble/assembly.xml
cleanoutput target is useless as doing the job of "mvn clean"
you should use "artifact:nuxeo-expand" instead of "artifact:expand"
FT job takes about four to seven minutes but the timeout is set on sixty minutes

Anyway, this is a good thing to run Selenium tests against addons too.
An improvement would be to make your script checkout 
https://svn.nuxeo.org/nuxeo/tools/qa/nuxeo-integration-release/trunk/integration-lib.sh
 ("svn export --force ...") in order to factorize and reuse common functions to 
all FT jobs. For example, checking server availability (check another server is 
not running, or kill it, ...).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
https://jira.nuxeo.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        
_______________________________________________
ECM-tickets mailing list
[email protected]
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets

Reply via email to