[
https://jira.nuxeo.com/browse/NXP-7465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=103895#comment-103895
]
Anahide Tchertchian commented on NXP-7465:
------------------------------------------
Hi,
Can you take the following comments into account?
- the @since notation is missing for your new classes (and event name).
- please chose a less generic name then "select_vocabulary_tree" (like
select_l10n_vocabulary_tree) as i'm not sure we'll be able to change this
widget type in a more generic widget later (so i'd like the generic name to be
available in case we do that at some point)
- some property names should be consistent with the one we already have on
other widgets (for instance, the simple vocabulary widget has a property
'displayObsoleteEntries' => use it instead of 'showObsolete' as well as
'multiSelect' that exists in chained directories instead of 'multipleValues') -
i'm not sure about 'selectIdOnly', is it for display or persistence? In both
cases, i think there are matching properties in chained selects.
- the widget properties cannot be defined using EL expressions in the template,
as there is no double resolution of expressions when using the expression
"widget.properties.showObsolete" so it would be better to switch to
widgetProperty_showObsolete (for instance) as the value will be resolved
correctly like this
- the key separator is hardcoded here ("/"), maybe it would be better to make
it configurable (still defaulting to "/"), also for consistency with existing
chain selects.
- thanks for documenting the widget, but please make also the title less
generic, and configure the properties: it's useful for documenting each of the
properties (see the "reference" tab in layout demo app), and will make our life
easier when making this widget type available in Studio (we'll just need to add
the category to the configuration when we'd like it to be available for export).
- a detail, but ui:repeat is buggy sometimes (see NXP-2163 resolved as "won't
fix") so it's better to use c:forEach instead (we'll need to remove this tag
from all templates at some point)
> Create a hierarchical and internationalized vocabulary widget
> -------------------------------------------------------------
>
> Key: NXP-7465
> URL: https://jira.nuxeo.com/browse/NXP-7465
> Project: Nuxeo Enterprise Platform
> Issue Type: New Feature
> Components: Layouts / Widgets
> Reporter: Benjamin Jalon
> Assignee: Quentin Lamerand
> Fix For: 5.4.3
>
> Attachments: l10n-widgets-config.xml
>
> Time Spent: 4 days, 4 hours
> Remaining Estimate: 0 minutes
>
> This widget will used the Tree component create into NXP-7464 issue.
> A new widget that will be bound to a internationalized vocabulary that will
> managed the edit mode (with the tree) and the view mode that will display
> translated each element stored into the field.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
_______________________________________________
ECM-tickets mailing list
[email protected]
http://lists.nuxeo.com/mailman/listinfo/ecm-tickets
