>>>>> "Andrew" == Andrew Lunn <[EMAIL PROTECTED]> writes:
Andrew> On Mon, Dec 19, 2005 at 03:40:16PM +0000, David Vrabel wrote:
>> Hi,
>>
>> The patches adds generic 8250/16x50 serial diagnostics routines
>> to hal/common. It's been tested with standard PC UARTs, IXP4xx
>> internal UARTs, and external UARTs on a PXA270 board. It likely
>> works for many other processor/UART combinations.
>>
>> I think this is preferable to the current practice of copying
>> all the routines whenever a new platform is implemented.
>>
>> UART quirks (e.g., the UUE bit on the internal UARTs of the
>> IXP4xx) are handled by a set of UART_FEATURE_XXX bits which are
>> provided on a per-port basis. Additional UART quirks can be
>> added as required.
Andrew> Hi David
Andrew> I like the idea, but not the location. I don't think this
Andrew> belongs in the hal/common directory.
Andrew> How about
Andrew> devs/serial/generic/16x5x-haldiag
I agree with Andrew that this does not belong in the common HAL. It
should go into either the existing devs/serial/generic/16x5x, thus
keeping all the 16x5x quirks in one package, or into a new
devs/serial/generic/16x5x-haldiag package. I have a slight preference
for the former but there may be too many existing CDL active_if
constraints in the way.
Bart
--
Bart Veer eCos Configuration Architect
http://www.ecoscentric.com/ The eCos and RedBoot experts
