Øyvind Harboe wrote: > Switched to using memcpy() for tftp get, which matters w/larger packet sizes.
Thanks. It would be good if you could tweak a few things: firstly, the use of sprintf means the CDL will need to require CYGINT_ISO_STDIO_FORMATTED_IO. Secondly, and I realise the problem was there before as well, but I am concerned that there are no boundary checks on overrunning the end of 'data', despite the variable length of filename (which could well originate from user input, so it's up to us to enforce our own size limits). I think this should be checked. Would you be able to do that? Finally, Since tftp_client_put is nearly identical in this respect, can you make a similar change to it? Seems strange to do one and not the other. Thanks again. Jifl -- eCosCentric Limited http://www.eCosCentric.com/ The eCos experts Barnwell House, Barnwell Drive, Cambridge, UK. Tel: +44 1223 245571 Registered in England and Wales: Reg No 4422071. ------["Si fractum non sit, noli id reficere"]------ Opinions==mine
