On Wed, Sep 03, 2008 at 02:07:25PM +0100, Steven Clugston wrote: > Attached is a board package for the MPC555 based board called a PATI > (PowerPC controlled Analog and Timing I/O Intelligence) MPL AG > Elektronik of Switzerland. > > Board info: > http://www.mpl.ch/t2864.html > > The board is a PC/104+ form factor PCI target that works stand-alone as > well. > > There's 16Mb RAM, and 4Mb flash which I think is quite a bit more than > cme555/ec555 boards. > > It is essentially intended as an intelligent data acquisition or > controller card. > The the mpc555 uP makes it useful for motor control and automotive > applications. > > I've based the package on the ec555 and cme555 packages by Bob Koninckx, > but the packages add support for the on-board 28fxx flash part, SDRAM > controller configuration, and board specific reset etc whilst making use > of the (now) generic mpc555 serial driver.
Hi Steve Thanks for the board port. Here are some comments: Please remove all the comments: ## Alternative licenses for eCos may be arranged by contacting Red Hat, Inc. ## at http://sources.redhat.com/ecos/ecos-license/ in the headers. This has not been true for years. Please change the copyright lines, eg: Copyright (C) 1998, 1999, 2000, 2001, 2002 Red Hat, Inc. to Copyright (C) 2008 Free Software Foundation, Inc. plf_misc.h has a long line it would be nice to split over two. mlt_powerpc_pati_ram.h has a commented out line which can be deleted. mlt_powerpc_pati_ram.h has two commented out line which can be deleted. hal_diag.c says // Default baudrate is 38400 // These values are calculated for a 40Mhz clock frequency // This should be enough, we did not provide clock frequency as a configuration // option anyway which is wrong, there is a CDL option for the clock frequency CYGHWR_HAL_POWERPC_BOARD_SPEED. hal_diag.c: I _think_ cyg_hal_plf_serial_getc, cyg_hal_plf_serial_putc, cyg_hal_plf_serial_write, cyg_hal_plf_serial_getc_timeout, and maybe cyg_hal_plf_comms_init can be made static. pati.s has a few long lines it would be nice to split. Also there are a few commented out instructions which should be deleted. plf_stub.c: The macros L1 and L2 do not appear to be used. redboot_R[OA]M.ecm have a couple of commented out lines which should be removed. I've not tried to compile anything yet, but my impression so far is it all looks good. Andrew
