http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000740
--- Comment #21 from Sergei Gavrikov <[email protected]> 2009-05-08 21:28:42 --- (In reply to comment #19) > (In reply to comment #18) > > (In reply to comment #16) > > > > > > The src/ecos/ code serves as a useful example of how to implement a > > > > real-world PDCurses application under eCos but it could be seen as > > > > unnecessarily restrictive. Perhaps better to drop CYGBLD_PDCURSES_ECOS, > > > > place the src/ecos/ code in a separate examples/ directory within the > > > > PDCurses package and provide a simple makefile similar to > > > > /opt/ecos/ecos-3.0/examples/Makefile in order to build it. > > > > > > It is good idea! Thank you, I will rework the package ASAP, re-test it > > > and let > > > you know. I put a simple Makefile and README in examples directory. If README will seem too bloat for you feel free to cut any lines or just remove it. > > > > Great! > > > > Some minor niggles: > > > > * The ChangeLog, HISTORY, IMPLEMNT and README files should be in the > > "pdcurses/current/" directory. Done. ChangeLog regenerated. > > > > * Please ensure you have included some comment about the precise PDCurses > > version you have ported. I could not find a version string but I did not > > look very hard. I used the latest stable version of the PDCurses. This is v 3.4: http://pdcurses.sourceforge.net/ and `include/curses.h' contains #define PDC_BUILD 3401 The PDCurses sources were tweaked a very few (if you desire you can brief look at the latest chapter: "The tweaks") from here http://bitbucket.org/tickling/pdcurses4ecos/src/tip/implement.txt > > * The empty "define_proc" in the CDL script can be removed. > > Removed. > > * For compatibility with the eCos Configuration Tool, the list of tests in > > CYGPKG_PDCURSES_TESTS should not include the ".c" suffix: > > > > tests/firework tests/newdemo ... Fixed. > > With the above changes and the change described in comment #15 I think > > contribution this will be ready for check-in. > > That's the BSM attachment (id=714) http://bugs.ecos.sourceware.org/attachment.cgi?id=714 or BB commit 52: 8968475009ef http://bitbucket.org/tickling/pdcurses4ecos/ Thank you for collaborating! -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.
