Uwe Kindler wrote: >> > to get this right - you would like to keep the original uSTL #if ... >> > definitions in the uSTL source instead of my #if defined ... changes and >> > to define the macros to 0 in config.h so that the changes to uSTL >> > source are kept to a minimum and most of the changes are in eCos >> > specific config.h file? But you would prefer to see my #if defined ... >> > changes in the official uSTL tree of Mike Sharov? > > I just tried to implement your proposed solution for macro definition > and stumbled about the inconsistent use of #ifdef and #if in uSTL port. > In some uSTL files a macro is checked with #ifdef while in another file > the same macro is checked via #if. So undefining the macro brings > warning for the #if check and defining the macro to 0 produces a wrong > result for #ifdef macros. So we would end up with a mix of you proposed > solution and changes in the uSTL source files. > > Therefore I would propose to stay with my current implementation because > it is consistent and it is safe. That means, we should stay with my > changes of all #if ... checks into #if defined ... checks. The number of > source files is not that big and changing this for a new version should > not be a big issue. > > I will keep trying to bring these changes into the official uSTL source > tree so that it will become easier in the future to import a new version. > > Do you agree with this proposal?
Yes. Thanks for investigating... John Dallaway
