On 09/22/2009 10:29 AM, Jay Foster wrote:
On 9/18/2009 7:49 AM, Gary Thomas wrote:
On 09/17/2009 05:08 PM, Jay Foster wrote:
The attached patch fixes the DHCP option parsing to deal with DHCP
servers that don't terminate their options with an END tag. The eCos
implementation relies heavily on this. RFC 2132 doesn't specify if this
END tag is required or not. Up until now, I have never seen a DHCP
server do this, but have run into now.

There are other ways to implement this, but I chose this approach as the
least invasive.

How about abstracting the 'recvfrom()+test+repair' sequence
to a function, since there are _four_ identical occurrences?

Attached is a revised patch.
Jay


Nicely done, checked in.

Thanks

--
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Reply via email to