Hi John

Sorry, that was pretty bad testing on my side ;) only did some tests on the synth target. The shortcomings are pretty obvious!

I'll fix the mistakes and post an updated patch.

Simon

On 06/28/2010 11:19 AM, John Dallaway wrote:
Hi Simon

Simon Kallweit wrote:

This patch will update uSTL to the newest 1.4 sources. Minor updates.

It seems that uSTL 1.4 has introduced a portability issue. Building the
tests for target "m5272c3" (for example):

m68k-elf-gcc -c  -I/var/tmp/ustl-test/install/include 
-I/var/local/cvs/ecos/packages/language/cxx/ustl/current 
-I/var/local/cvs/ecos/packages/language/cxx/ustl/current/src 
-I/var/local/cvs/ecos/packages/language/cxx/ustl/current/tests -I. 
-I/var/local/cvs/ecos/packages/language/cxx/ustl/current/tests/ 
-finline-limit=7000 -Wall -Wpointer-arith  -Woverloaded-virtual 
-Wno-write-strings -mcpu=5272 -malign-int -g -O2 -ffunction-sections 
-fdata-sections -fno-rtti -fno-exceptions -fomit-frame-pointer 
-I/var/tmp/ustl-test/install/include/ustl -Wp,-MD,tests/bvt21.tmp -o 
tests/bvt21.o 
/var/local/cvs/ecos/packages/language/cxx/ustl/current/tests/bvt21.cpp
/var/tmp/ustl-test/install/include/ustl/uutility.h: In function ‘void 
TestUtility()’:
/var/tmp/ustl-test/install/include/ustl/uutility.h:350: error: impossible 
constraint in ‘asm’
/var/tmp/ustl-test/install/include/ustl/uutility.h:350: error: impossible 
constraint in ‘asm’
/var/tmp/ustl-test/install/include/ustl/uutility.h:350: error: impossible 
constraint in ‘asm’
/var/tmp/ustl-test/install/include/ustl/uutility.h:350: error: impossible 
constraint in ‘asm’
/var/tmp/ustl-test/install/include/ustl/uutility.h:350: error: impossible 
constraint in ‘asm’
make[1]: *** [tests/bvt21.d] Error 1
make[1]: Leaving directory `/var/tmp/ustl-test/language/cxx/ustl/current'
make: *** [tests] Error 2

Are you able to provide a portable implementation of NextPow2() and
submit upstream?

Note also that your patch to include/ustl/uctrstrm.h prevents building
uSTL with "-fno-rtti" and should be omitted.

I'm copying Uwe Kindler to ensure he's aware of your contribution.

John Dallaway
eCos maintainers

Reply via email to