Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001070
Sergei Gavrikov <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #1 from Sergei Gavrikov <[email protected]> 2010-11-09 09:53:26 GMT --- Hi Jean-Francois, I plan to work on your patch as I have similar hardware. I have only one comment on the patch. My concern is about using new CDL option: CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE This CDL option (=name) is used 1) to fix the memory layout files, 2) to set new bus timings both for RAM and NVRAM components, and 3) to select proper FLASH parts for the hardware variant. As I said I would prefer to see in HAL just one eCos CDL component which wraps one or more CDL options, something like this (draft, not tested) cdl_componet CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT { display "OLPCL2294 variant used" flavor data default_value { "OLPCL2294_1M" } legal_values { "OLPCL2294_1M" "OLPCL2294_8M" } define -file system.h CYGHWR_BOARD description " Blah, blah, blah." cdl_option CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE { display "External RAM size" flavor data calculated { is_substr(CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_VARIANT, "1M") ? 0x100000 : 0x800000 } description " Blah, blah, blah." } # More CDL options? } So, your code would use CYGHWR_BOARD_OLPCL2294_xM checks anywhere and CDL option CYGHWR_HAL_ARM_LPC2XXX_OLPCL2294_RAMSIZE can be used in MLT only. If you want you would add more CDL options in this component to implement your TODOs (like overwriting those config values for LPC BANKx registers in HAL startup code, but, IMO, it is excessively). Also, it will be nice to manage HAL_PLATFORM_EXTRA definition, to set its value in either "1M" or "8M", that would show a proper hint in RedBoot (however, it is beyond the scope your patch). If you are familiar with CDL, can you, please, fix the patch (at least to wrap RAMSIZE option in CDL component)? Otherwise, I would help to make some changes. Sergei -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
