Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001116
--- Comment #15 from Ilija Kocho <[email protected]> 2011-01-29 19:48:52 GMT --- (In reply to comment #13) > Hi > So far it is about the below, > > - Concatenation or plain strings? > > I prefer the plain strings. If we do not keep the other macros that depend on CYGDAT_LWIP_MEM_SECTION_NAME then I'll be happy with plain strings. If we keep them then the concatenation is a convenience. Note: (my error in last CDL proposal) If we keep the macros, CYGDAT_LWIP_MEM_SECTION_NAME can't have no_define flag. > > IMO it would depend on resolution for section related macros proposed in > > http://bugs.ecos.sourceware.org/attachment.cgi?id=1088 to Bug 1001114 . > > > > For reference, here is a digest of all code snippets as are in my current > > build: > > > ----------------- > > cdl_package CYGPKG_NET_LWIP { > > ... > > cdl_option CYGDAT_LWIP_MEM_SECTION { > > display "Special memory section for lwIP buffers." > > active_if CYGDAT_LWIP_MEM_SECTION_NAME > > requires CYGDAT_LWIP_MEM_SECTION_NAME > > flavor data > > calculated { "\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\"" } > > description "..." > > } > > ... > > } > > I dislike the above as the most users will be to see in CT a strange grayed > data box like below: > > - |__) Momory options > [ab] "Special memory section for lwIP buffers." | ".0" > > What's that ".0"? That's concatenation with an absent data. Thanks for remarks, you're right, this is ugly and looks awkward. A way to improve: calculated { CYGDAT_LWIP_MEM_SECTION_NAME ? "\"." . CYGDAT_LWIP_MEM_SECTION_NAME . "\"" : "none" } or equivalent with plain strings: calculated { CYGDAT_LWIP_MEM_SECTION_NAME ? CYGDAT_LWIP_MEM_SECTION_NAME : "none" } Note: Even if we end up with plain strings I would rather keep CYGDAT_LWIP_MEM_SECTION data than bool. IMO "none" is rather descriptive. Comments? -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
