Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001184
--- Comment #3 from Ilija Kocho <[email protected]> 2011-04-03 23:37:49 BST --- (In reply to comment #2) > (In reply on comment #0) > > Created an attachment (id=1195) --> (http://bugs.ecos.sourceware.org/attachment.cgi?id=1195) [details] > > Include var_intr.h after definition of hal_intr.h macros but allows > > overriding of CYGNUM_HAL_INTERRUPT_RTC. > > > > In Cortex-M architecture, the header hal_intr.h includes var_intr.h > > twice. Second one is of course with no effect, but the first one is > > too early. Namely some macros that are defined in hal_intr.h, such as > > CYGNUM_HAL_INTERRUPT_EXTERNAL, are used in hal-intr.h. This doesn't > > seem to show ill effect so far since usage is by other macros. > > > > Note: The early inclusion of var_intr.h has been introduced by Bug > > 1001090 Attachment 1092 [details] in order to enable overriding of > > CYGNUM_HAL_INTERRUPT_RTC by variant/platform. > > > > The proposed patch includes var_intr.h after definition of hal_intr.h > > macros but also allows overriding of CYGNUM_HAL_INTERRUPT_RTC. > > Thanks for catch. On my look CYGNUM_HAL_INTERRUPT_RTC definition became > misplaced lines via that request (no header, in fact). So, I would shift > down the definition and point on this on CL entry. Certainly, the first > inclusion of the header can be removed safely then. Thanks for the reply Sergei. As far as I understand you are going to revert hal_intr.h to state before Attachment 1092 and in addition shift CYGNUM_HAL_INTERRUPT_RTC definition after inclusion of var_intr.h. Am I right? It would fit, since var_intr.h shall be included after definition of Cortex-M system vectors and before CYGNUM_HAL_INTERRUPT_RTC. -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
