Please do not reply to this email. Use the web interface provided at:
http://bugs.ecos.sourceware.org/show_bug.cgi?id=1001539
--- Comment #20 from Sergei Gavrikov <sergei.gavri...@gmail.com> 2012-03-22
18:05:34 GMT ---
(In reply to comment #19)
> > Tests expect NaN for out-of-domain arguments, but functions return
> > something else. For instance asinf(10) returns 0. Here is a little
> > example:
>
> IMO, it can depend on libm compatibility, look at libm compat.
> wrappers (w_*.c), e.g. at w_asin{,f}.c. Though, I think in our case
> it should be a result of call __ieee754_asin{,f}(). And if libm
> compat mode is not IEEE? I'm looking at misc/standard.c
> (__kernel_standard)...
Well, I understand what is wrong. Let's take `wf_asin.c', "i wonder"
hack:
--- a/packages/language/c/libm/current/src/float/ieee754-api/wf_asin.c
+++ b/packages/language/c/libm/current/src/float/ieee754-api/wf_asin.c
@@ -88,8 +88,10 @@
#ifdef CYGSEM_LIBM_COMPAT_IEEE_ONLY
return __ieee754_asinf(x);
#else
- double z;
+ float z;
z = __ieee754_asinf(x);
+ printf("__ieee754_asinf(%f)=%f\n", x, z);
+ return z;
if(cyg_libm_get_compat_mode() == CYGNUM_LIBM_COMPAT_IEEE || isnanf(x))
return z;
if(fabs(x)>1.0) {
return __kernel_standard(x,x,2); /* asin(|x|>1) */
Then let's run `asinf' (a picture worth more than many words)
INFO:<Still crunching, please wait...>
__ieee754_asinf(-1.200000)=nan
__ieee754_asinf(-1.190000)=nan
...
__ieee754_asinf(-1.010000)=nan
__ieee754_asinf(-1.000000)=-1.570796
...
__ieee754_asinf(0.000000)=0.000000
__ieee754_asinf(0.000000)=0.000000
INFO:<Still crunching, please wait...>
__ieee754_asinf(0.000000)=0.000000
PASS:<asinf() is stable>
EXIT:<Finished tests from testcase
/home/sg/repo/ecos-hg/packages/language/c/libm/current/tests/vectors/asinf.c
for Math library asinf() function>
Thus, IMHO, you have to implement own __kernel_standard_float() and
maybe another "float" wrappers to peace failed f-tests.
FYI, import
cdl_option CYGSEM_LIBM_COMPAT_IEEE_ONLY {
user_value 1
};
breaks build of single precision tests. Some your headers have EDOM
used, but this value is not defined for such config conditions. Perhaps,
you need weak definition for that in `vector_support_float.h' header.
// Not tested
#ifdef CYGSEM_LIBM_COMPAT_IEEE_ONLY
# ifndef EDOM
# define EDOM 33
# endif
#endif
Sergei
--
Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
