Please do not reply to this email. Use the web interface provided at: http://bugs.ecos.sourceware.org/show_bug.cgi?id=1000910
--- Comment #18 from Jonathan Larmour <[email protected]> 2012-04-05 16:51:40 BST --- (In reply to comment #17) > (In reply to comment #16) > Hi Jonathan, > > > - In the CDL you don't want to use > > !is_active(CYGINT_IO_ETH_INT_SUPPORT_REQUIRED), is it will always be active > > if > > the package is included which it always would be. > > I think that RedBoot is a case where package CYGPKG_DEVS_ETH_ENC424J600 is > included and CYGINT_IO_ETH_INT_SUPPORT_REQUIRED is not active. I think it is active. Look at a redboot build's ecos.ecc file. You will see for other options it clearly says "This option is not active". For CYGINT_IO_ETH_INT_SUPPORT_REQUIRED it does not say that. Remember that active is different from enabled. > > Instead you want something like: > > > > requires { CYGINT_IO_ETH_INT_SUPPORT_REQUIRED implies > > (CYGNUM_DEVS_ETH_ENC424J600_INTERRUPT_VECTOR != "\"\"") } > > > > (and the same for _PRIORITY) > > Anyway, this above is better. Then problem solved :-). [snip other stuff which is fine, no need for me to acknowledge] > > - On committing I will probably just tidy up a few of the CDL descriptions > > for > > English clarity, please don't be offended! > > I'll do my best. As I said, please don't be offended! > > - Think of how the CDL will look in the graphical config tool - "STM32 HAL > > resources assigned to SPI Ethernet controller" is a very long string to > > display. It would be better just as "Optional ENC424J600 SPI Ethernet" > > > > Your suggestion isn't optimal because this component is parented in > CYGPKG_DEVS_ETH_ENC424J600, so in configtool it appears there. True, good point. > The title should > depict the component as part of HAL. You are right about the length, it should > be shorter. I'll try "STM32 HAL resources" and some better description. Thanks. [snip] > I will update with recent changes to stm3210e then I will submit the changes. Thank you for bearing with me! The result will be better quality which will no doubt be appreciated by many :-). Jifl -- Configure bugmail: http://bugs.ecos.sourceware.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.
