On Wed, Sep 19, 2007 at 10:46:26PM -0700, Andrew Morton wrote:
(from ecryptfs_encrypt_page()):
> > + enc_extent_virt = kmalloc(PAGE_CACHE_SIZE, GFP_USER);
>
> I'd have thought that alloc_page() would be nicer. After all, we _are_
> treating it as a page, and not as a random piece of memry.
>
> > + if (!enc_extent_virt) {
> > + rc = -ENOMEM;
> > + ecryptfs_printk(KERN_ERR, "Error allocating memory for "
> > + "encrypted extent\n");
> > + goto out;
> > + }
> > + enc_extent_page = virt_to_page(enc_extent_virt);
>
> And then we don't need this.
If neither kmap() nor kmap_atomic() can be safely used to get a
virtual address to pass to vfs_write(), then I do not know what my
other options are here.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
eCryptfs-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ecryptfs-devel
