Please guide me, as this is my first post to a mailing list, as well as my 
first attempt at contrubiting to an open-source project.
Thank you,
Ryan

## The Problem:

HTML generated is:

...<OPTION>Option 1<OPTION>Option 2<OPTION>Option 3</SELECT>

## The Need:

HTML generated to be:

...<OPTION>Option 1</OPTION><OPTION>Option 2</OPTION>...

## Details:

   I'm using Turbine's SelectorBox class, which in turn uses the ECS Option 
class.  The HTML genereated does not contain closing </OPTION> tags.  This in 
turns causes my test scripts to fail (it should be noted that the actual HTML 
page looks just fine.)  I have updated Option.java, passing 'true' to 
'setNeedClosingTag'.  

   The current code explicitly indicates that no closing tag is desired.  This 
makes wonder if there is intent behind it?

   Reference?: http://www.w3.org/TR/html4/interact/forms.html#h-17.6

## The patch:

Index: Option.java
===================================================================
RCS file: /home/cvspublic/jakarta-ecs/src/java/org/apache/ecs/html/Option.java,v
retrieving revision 1.3
diff -u -u -r1.3 Option.java
--- Option.java 1999/10/08 01:38:04     1.3
+++ Option.java 2001/03/28 23:41:14
@@ -60,7 +60,7 @@
     because it is optional in the spec. This can be
     overridden by setNeedClosingTag(true)
 
-    @version $Id: Option.java,v 1.3 1999/10/08 01:38:04 jonbolt Exp $
+    @version $Id: Option.java,v 1.2 2001/03/28 19:46:51 ryan Exp $
     @author <a href="mailto:[EMAIL PROTECTED]">Stephan Nagy</a>
     @author <a href="mailto:[EMAIL PROTECTED]">Jon S. Stevens</a>
 */
@@ -73,7 +73,7 @@
     */
     {
         setElementType("option");
-        setNeedClosingTag(false);
+        setNeedClosingTag(true);
     }
     
     /**
@@ -440,4 +440,4 @@
     {
         addAttribute ( "onKeyUp", script );
     }
-}
\ No newline at end of file
+}


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to