On Fri, Jan 24, 2014 at 06:21:21AM -0800, Chris Brannon wrote: > Adam Thompson <[email protected]> writes: > > >> We should not be passing unrooted jsval as the fourth > >> argument to JS_DefineProperty as this can also lead to a crash. > > > > Yeah, I'm not sure how to work around this. > > I am, and a patch is attached. There may be other cases. I can look through > the code for them. I fixed the one I noticed.
Ah, ok, I see what you mean. I've looked through and *hopefully* fixed a bunch of them. I've definitely pushed the set of commits now (git push origin master) so hoefully you can see them. In addition I think we need to change the establish_property_* functions to take JS::Handle and js::MutableHandle arguments. Cheers, Adam. _______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
