On Wed, Jan 29, 2014 at 03:41:24PM -0800, Chris Brannon wrote: > Chuck Hallenbeck <[email protected]> writes: > > So don't modify the makefile. I'd suggest a script like this one: > > #!/bin/sh > # ebmake, build edbrowse > # Expects to be run from the root of the edbrowse tree, > > LDFLAGS=-L/usr/local/lib make JS_CXXFLAGS=/usr/local/include/mozjs-24 > # End of script. > > This is sort of how we do things when packaging for distributions. > Typically, we don't write patches against the makefile, because they're > fragile. It's better to set variables or flip configure switches. > Since edbrowse doesn't have a configure script, we end up setting > environment variables, or in the case of JS_CXXFLAGS, "make" variables. > Don't make the mistake of using JS_CXXFLAGS as an environment variable, > because make will override it.
Good point. > Instead, it needs to be passed after the make command, so make will do > the substitution: > make JS_CXXFLAGS=whatever You may also want to add -Wno-invalid-offsetof to the JS_CXXFLAGS variable to prevent *lots* of warnings about stuff in various mozjs-24 headers. Cheers, Adam. _______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
