On Tue, Feb 11, 2014 at 06:55:22AM -0500, Karl Dahlke wrote: > A question for you in jsdom.cpp function domLink(). > This line > > JS::RootedObject owner_root(cw->jss->jcx, owner); > > Then you use owner_root instead of owner thereafter. > Is this necessary? > owner is safely rooted on the heap and isn't going to go anywhere. > We could just use owner throughout and it would be much clearer.
That's from when the html parser wasn't js-aware, I've just pushed a change rectifying this (removing owner_root). Cheers, Adam. _______________________________________________ Edbrowse-dev mailing list [email protected] http://lists.the-brannons.com/mailman/listinfo/edbrowse-dev
